On Mon, 18 Jun 2012 22:20:33 +0300 Martin Grigorov <[email protected]> wrote:
> Hi Carl-Eric, > > I also think that having onBeforeFormSubmit and onAfterFormSubmit in > IFormSubmitter will make this much clearer for the user. > Deprecate onSubmit() in 1.5 and remove it for 6.0. I agree it is clearer - the only thing that still bugs me is that the extension interface for the new methods (so far I'm calling it IBeforeAndAfterFormSubmitter extends IFormSubmitter) is not *that* nice. It's only for 1.5 compatibility though and won't show up in 6. > On Fri, Jun 15, 2012 at 5:30 PM, Carl-Eric Menzel > <[email protected]> wrote: > > Since it hit me today too, I had a look at this ticket: > > > > https://issues.apache.org/jira/browse/WICKET-4575 > > > > Thinking a bit too fast maybe, I implemented a simple and clean > > solution based on an enum BEFORE_FORM and AFTER_FORM that allows an > > ISubmittingComponent to choose whether it wants to run before or > > after the form. > > > > In the comments on that ticket I had a look at how to offer that in > > 1.5 too, and whether a different approach might be better. I'll be > > able to take another look at this tonight. Any opinions? > > > > Carl-Eric > > >
