Hi, On Wed, Jul 18, 2012 at 11:10 PM, Bertrand Guay-Paquet <[email protected]> wrote: > Hi, > > I finally got around to try Wicket 6 with this release. Porting my > application from 1.5 has been relatively fast. The only part which is not > ported yet is my own integration of jQueryUI based on a mix of JQWicket and > wiQuery. > > Besides my custom jQueryUI integration, the modifications requiring the most > work were the addition of another generic type to IColumn, the changes to > the Provider interface (longs instead of ints) and the replacement of > AjaxCallDecorators. > > Personally, I'm not a big fan of the change to longs for Providers because > as noted in WICKET-1175, it doesn't really solve the mismatch between JPA > and Wicket (see TypedQuery#setFirstResult(int) and friends). Also, using > lists as a backing store for a provider now requires casting from long to > int because longs cannot be used with List#subList(). I guess at this point > however, we'll just have to live with it! > > Some comments and questions regarding the migration docs: > Should be added to migration doc: > -MinimumValidator and MaximumValidator are replaced by > RangeValidator.minimum and RangeValidator.maximum respectively
The Wiki is editable by everyone with an account. Just create one and contribute! ;-) > > From https://cwiki.apache.org/confluence/display/WICKET/Wicket+Ajax : > -Very interesting read! If feel it really gave me a good overview of the new > Wicket ajax support. > > -There are references to > IJavaScriptLibrarySettings#setBackingLibraryReference which does not exist > anymore. Is it still possible to change the backing library? I personally > don't want to, but the disparity between the doc and the code confused me. Fixed! org.apache.wicket.settings.IJavaScriptLibrarySettings#setJQueryReference > > -Both updateAjaxAttributes exemples include a call to super() but the > javadoc does not mention that calling super() is required. Is it? It is not required but it is a good practice. All super impls are currently empty. > > -In the AjaxRequestAttributes table, the "preconditions" entry should be > folded in "ajax call listeners" to be consistent. Also, after reading the > code and the text below in "Migration steps", I noticed "ajax call > listeners" is missing the "bsh" and "coh" short names. Improved! > > -In the ajax listener points description, does the "complete handler" > execute after "success handler" or "failure handler" or before? The bullet > point order suggests that it executes after but it's not totally clear. > Perhaps using an ordered list for the listener points or modifying the > description of "complete handler" would clear things up. Complete handles are executed after either the success or the failure handlers (if there are any). I've updated the Wiki page but feel free to further improve it! > > Thanks for the great work! > Bertrand Welcome! Thanks for the feedback! -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
