+1 Tested : - build from source - our app - various wicket-examples
P.S. I've updated my script and next time the Git archive will have the folder (git archive --prefix). The previous releases also had the same problem and no one complained about it so far, so I think it is not a stopper. On Tue, Nov 6, 2012 at 3:58 PM, Martijn Dashorst <[email protected] > wrote: > +1 provided you don't mind the issue described below. Tested building > from the package, created an archetype, ran the examples, checked the > signing. > > Thing I found (I'd rather have it fixed, but don't think it is a > blocker for a release): > > The tar ball doesn't extract to a subfolder, but rather directly to > the current folder. > > I assume you created the tar ball using git archive. This has the > option to add a prefix: > > git archive --format=tar.gz --prefix=apache-wicket-$version/ -o > target/dist/apache-wicket-$version.tar.gz $tag > > Make sure you add a trailing '/' to the --prefix, otherwise it won't work. > > Martijn > > On Tue, Nov 6, 2012 at 10:34 AM, Martin Grigorov <[email protected]> > wrote: > > This vote is to release Apache Wicket 1.5.9 > > > > Git repo > > http://git-wip-us.apache.org/repos/asf/wicket.git > > > > Branch name > > build/wicket-1.5.9 > > > > Archived and signed Git repo > > http://people.apache.org/~mgrigorov/wicket-1.5.9/ > > > > Changelog > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12322962 > > > > This vote ends Friday, November 9 at 12:00 (GMT+2) > > > > Please test the release and offer your vote. > > > > The Wicket team! > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
