>Statics make me cringe
Me too.
I'm not sure about the need of an AtomicLong. I've just took the easy
route and changed it to how RepeatingView works.
> why does the counter have to be globally unique?
See my last comment on the issue: It's just that toolbars have an auto
generated id (for convenience?).
Sven
On 11/08/2012 11:26 AM, Martijn Dashorst wrote:
On Thu, Nov 8, 2012 at 11:24 AM, Martijn Dashorst
<[email protected]> wrote:
On Thu, Nov 8, 2012 at 10:02 AM, <[email protected]> wrote:
- private static int counter = 0;
+ /** Counter used for generating unique component ids. */
+ private static long counter = 0;
Should this be an AtomicLong instead? Statics make me cringe in a
multithreaded environment.
On second thought: why does the counter have to be globally unique?
Doesn't that make it rather an issue with long running applications
where markup ids generated from component ids get very long?
Martijn
