Yes, this change in the produced HTML is needed to be able to recreate a
page.
One question: will the link still be ?xxxxx (without className in front) if
the setting is 'false' ?


On Wed, Jan 9, 2013 at 11:24 PM, <[email protected]> wrote:

> Updated Branches:
>   refs/heads/sandbox/bookmarkable-callback-url 46a3a6a1f -> fba8bddd9
>
>
> WICKET-4932: fixing callback url expectations in bookmarkable pages
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fba8bddd
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fba8bddd
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fba8bddd
>
> Branch: refs/heads/sandbox/bookmarkable-callback-url
> Commit: fba8bddd98da943ea74c9c04d90f17c75417c2fe
> Parents: 46a3a6a
> Author: Pedro Santos <[email protected]>
> Authored: Wed Jan 9 19:24:41 2013 -0200
> Committer: Pedro Santos <[email protected]>
> Committed: Wed Jan 9 19:24:41 2013 -0200
>
> ----------------------------------------------------------------------
>  .../wicket/DisabledComponentPage1a_result.html     |    2 +-
>  .../html/list/PagedTablePageExpectedResult.html    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/fba8bddd/wicket-core/src/test/java/org/apache/wicket/DisabledComponentPage1a_result.html
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/test/java/org/apache/wicket/DisabledComponentPage1a_result.html
> b/wicket-core/src/test/java/org/apache/wicket/DisabledComponentPage1a_result.html
> index b27046d..787fee4 100644
> ---
> a/wicket-core/src/test/java/org/apache/wicket/DisabledComponentPage1a_result.html
> +++
> b/wicket-core/src/test/java/org/apache/wicket/DisabledComponentPage1a_result.html
> @@ -1,5 +1,5 @@
>  <html xmlns:wicket>
>  <body>
> -<a href="../page?0-1.ILinkListener-link" wicket:id="link">test</a>
> +<a
> href="./org.apache.wicket.DisabledComponentPage1?0-1.ILinkListener-link"
> wicket:id="link">test</a>
>  </body>
>  </html>
> \ No newline at end of file
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/fba8bddd/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePageExpectedResult.html
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePageExpectedResult.html
> b/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePageExpectedResult.html
> index 63766e5..9d0a3e3 100644
> ---
> a/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePageExpectedResult.html
> +++
> b/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePageExpectedResult.html
> @@ -17,6 +17,6 @@
>  <title>Paged Table Page</title>
>  </head>
>  <body><ul><li wicket:id="table"><span
> wicket:id="txt">three</span></li></ul>
> -<ul><li wicket:id="navigation"><a wicket:id="pageLink"
> href="../page?1-2.ILinkListener-navigation-0-pageLink" title="Go to page
> 1"><span wicket:id="pageNumber">1</span></a></li><li
> wicket:id="navigation"><span wicket:id="pageLink" title="Go to page
> 2"><em><span wicket:id="pageNumber">2</span></em></span></li></ul>
> +<ul><li wicket:id="navigation"><a wicket:id="pageLink"
> href="./org.apache.wicket.markup.html.list.PagedTablePage?1-2.ILinkListener-navigation-0-pageLink"
> title="Go to page 1"><span wicket:id="pageNumber">1</span></a></li><li
> wicket:id="navigation"><span wicket:id="pageLink" title="Go to page
> 2"><em><span wicket:id="pageNumber">2</span></em></span></li></ul>
>  </body>
>  </html>
>
>


-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>

Reply via email to