On Fri, Jan 11, 2013 at 11:09 AM, Sven Meier <[email protected]> wrote:
> Many thanks for your integration of QUnit :) > I'm glad you like it! :-) I find it very useful for integration tests too: http://wicketinaction.com/2012/11/javascript-based-functional-testing/ > > Sven > > http://git-wip-us.apache.org/**repos/asf/wicket/blob/** > 40b8e890/wicket-core/src/test/**js/form.js<http://git-wip-us.apache.org/repos/asf/wicket/blob/40b8e890/wicket-core/src/test/js/form.js> > ------------------------------**------------------------------**---------- > diff --git a/wicket-core/src/test/js/**form.js b/wicket-core/src/test/js/* > *form.js > index bf298b2..462526f 100644 > --- a/wicket-core/src/test/js/**form.js > +++ b/wicket-core/src/test/js/**form.js > @@ -178,8 +178,8 @@ jQuery(document).ready(**function() { > var $nestedForm = jQuery( > "<form>" + > + "<input type='text' name='textInput' > value='textInputValue'/>" + > "<div id='nestedForm'>" + > - "<input type='text' > name='textInput' value='textInputValue'/>" + > "<input type='checkbox' > name='checkboxInput' value='checkboxInputValue' checked/>" + > "<input type='checkbox' > name='checkboxInput' value='checkboxInputValue' checked/>" + // second time > "<input type='radio' > name='radioInput' value='radioInputValue' checked/>" + > > > > On 01/11/2013 09:40 AM, Martin Grigorov wrote: > >> To avoid regressions it would be good if the respective test is updated >> too: >> https://github.com/apache/**wicket/blob/master/wicket-** >> core/src/test/js/form.js#L175<https://github.com/apache/wicket/blob/master/wicket-core/src/test/js/form.js#L175> >> I'll do it next week if no one do it before me. >> >> >> On Thu, Jan 10, 2013 at 11:16 PM, <[email protected]> wrote: >> >> Updated Branches: >>> refs/heads/master a92efff89 -> 90abd22b2 >>> >>> >>> WICKET-4961 serialize elements of parental forms >>> >>> Project: >>> http://git-wip-us.apache.org/**repos/asf/wicket/repo<http://git-wip-us.apache.org/repos/asf/wicket/repo> >>> Commit: http://git-wip-us.apache.org/**repos/asf/wicket/commit/** >>> 90abd22b <http://git-wip-us.apache.org/repos/asf/wicket/commit/90abd22b> >>> Tree: >>> http://git-wip-us.apache.org/**repos/asf/wicket/tree/90abd22b<http://git-wip-us.apache.org/repos/asf/wicket/tree/90abd22b> >>> Diff: >>> http://git-wip-us.apache.org/**repos/asf/wicket/diff/90abd22b<http://git-wip-us.apache.org/repos/asf/wicket/diff/90abd22b> >>> >>> Branch: refs/heads/master >>> Commit: 90abd22b22bfbd4399781a3d6283b2**4e0adc6d8e >>> Parents: a92efff >>> Author: svenmeier <[email protected]> >>> Authored: Thu Jan 10 22:15:14 2013 +0100 >>> Committer: svenmeier <[email protected]> >>> Committed: Thu Jan 10 22:15:14 2013 +0100 >>> >>> ------------------------------**------------------------------** >>> ---------- >>> .../wicket/ajax/res/js/wicket-**ajax-jquery.js | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> ------------------------------**------------------------------** >>> ---------- >>> >>> >>> >>> http://git-wip-us.apache.org/**repos/asf/wicket/blob/** >>> 90abd22b/wicket-core/src/main/**java/org/apache/wicket/ajax/** >>> res/js/wicket-ajax-jquery.js<http://git-wip-us.apache.org/repos/asf/wicket/blob/90abd22b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js> >>> ------------------------------**------------------------------** >>> ---------- >>> diff --git >>> a/wicket-core/src/main/java/**org/apache/wicket/ajax/res/js/** >>> wicket-ajax-jquery.js >>> b/wicket-core/src/main/java/**org/apache/wicket/ajax/res/js/** >>> wicket-ajax-jquery.js >>> index dbbf96e..e16e1a8 100644 >>> --- >>> a/wicket-core/src/main/java/**org/apache/wicket/ajax/res/js/** >>> wicket-ajax-jquery.js >>> +++ >>> b/wicket-core/src/main/java/**org/apache/wicket/ajax/res/js/** >>> wicket-ajax-jquery.js >>> @@ -1328,6 +1328,10 @@ >>> if (form.tagName.toLowerCase() >>> === >>> 'form') { >>> elements = >>> form.elements; >>> } else { >>> + do { >>> + form = >>> form.parentNode; >>> + } >>> while(form.tagName.**toLowerCase() != "form" && >>> element.tagName.toLowerCase() >>> != "body") >>> + >>> elements = >>> nodeListToArray(form.**getElementsByTagName("input"))**; >>> elements = >>> elements.concat(**nodeListToArray(form.**getElementsByTagName("select")* >>> *)); >>> elements = >>> elements.concat(**nodeListToArray(form.**getElementsByTagName("** >>> textarea"))); >>> >>> >>> >> > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
