On Tue, Jan 15, 2013 at 1:30 PM, Emond Papegaaij <[email protected]>wrote:
> I've synced all settings with core and added the new files (which probably > only contain some defaults). I agree with Martin that settings file in the > source tree make it difficult to maintain them, unfortunately m2e does not > I'm didn't mean that. I'm saying that I've seen updates to these files in the same commit with some functional change without explanation what is changed in the settings, so non-Eclipse users canntot follow up. For Eclipse users it is easy - next time you load the project the new settings are automatically applied. I think m2e and maven-eclipse-plugin manipulate different files in .settings/** so this should not be a problem. > (yet) support importing settings from a maven artifact. Hopefully they add > this some time.... > I'm not sure what you talk about. Maven's pom.xml doesn't contain any code style rules which can be consumed by IDE plugins like m2e, maven-eclipse-plugin, ... If there is anything in the pom.xml then it is something specific to m2e, m-e-p, ... but not something generic. M2E has something very ugly (IMO) - its lifecycle mapping from Maven phases to Eclipse. I hope this will never go in Wicket pom.xml files now when you move to m2e. > > Best regards, > Emond > > > On Tue, Jan 15, 2013 at 12:14 PM, Martin Grigorov <[email protected] > >wrote: > > > There is another problem with these files in .settings. > > Many times developers change them without explanation what exactly is the > > change. Please don't ask me to review the commits with such changes. > > This makes it impossible for me (user of a different IDE) to update my > code > > style settings ( > > > > > https://github.com/martin-g/dotfiles/blob/master/.IntelliJIdea11/config/codestyles/wicket.xml > > ). > > If I commit something that doesn't match the current code style rules > > please tell me and I'll update my config. > > > > > > On Tue, Jan 15, 2013 at 12:57 PM, Emond Papegaaij < > > [email protected] > > > wrote: > > > > > The new files seem to be about wst and require a multi-faceted project, > > > which is what m2e creates. I don't think they will cause problems if > you > > do > > > not have a multi-faceted project or if wst is not installed. > > > > > > If our primary goal is to get consistent behavior, shouldn't all > projects > > > have the same settings? At the moment the differences are quite big, > some > > > projects don't even seem to have any settings. Shall I copy the > settings > > > from core to all other modules? > > > > > > Best regards, > > > Emond > > > > > > > > > On Mon, Jan 14, 2013 at 6:03 PM, Johan Compagner <[email protected] > > > >wrote: > > > > > > > those files are needed, at least to get a consistent formatting > > behavior > > > > across all developers. > > > > I would say just commit those files. Thats the whole point of the > > > .settings > > > > dir in eclipse.. (else don't specify anything at the project level) > > > > > > > > > > > > On 14 January 2013 13:27, Emond Papegaaij < > [email protected] > > > > >wrote: > > > > > > > > > I just accidently pushed the changes to these files, so I hope > noone > > > > > objects > > > > > :) If it's not ok, I've no problem with reverting these 2 commits. > > > > > > > > > > Emond > > > > > > > > > > On Monday 14 January 2013 09:02:47 Emond Papegaaij wrote: > > > > > > Hi all, > > > > > > > > > > > > The Eclipse settings files keep causing trouble for me. I've > > recently > > > > > > switched from the maven-eclipse-plugin to M2e. The first is > > > deprecated > > > > > and > > > > > > the latter has become much more stable lately and provides a much > > > > better > > > > > > integration of Maven in Eclipse. However, M2e changes the > > > > > > org.eclipse.jdt.core.prefs files in all projects and adds quite a > > few > > > > new > > > > > > files. These changed files make it impossible to rebase without > > > > stashing > > > > > > them first, which in turn requires me to close Eclipse. > > > > > > > > > > > > My question is: what should we do with these settings files? In > my > > > > > opinion > > > > > > they do not belong in the source, they should be added when > > importing > > > > the > > > > > > projects and ignored by git. However, M2e does not (yet?) support > > > > > importing > > > > > > eclipse settings (it is possible with this plugin: > > > > > > https://github.com/papegaaij/m2e-settings, but that requires > > > manually > > > > > adding > > > > > > a plugin to Eclipse). So for now, I propose to upgrade the core > > > setting > > > > > > files to Eclipse Juno and add .settings to .gitignore to ignore > all > > > > other > > > > > > files. Is that ok, or does anyone have a better solution? > > > > > > > > > > > > Best regards, > > > > > > Emond > > > > > > > > > > > > > > > > > > > > -- > > Martin Grigorov > > jWeekend > > Training, Consulting, Development > > http://jWeekend.com <http://jweekend.com/> > > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
