On 15.01.2013, at 10:34, Martin Grigorov <[email protected]> wrote:

> On Tue, Jan 15, 2013 at 11:30 AM, Thomas Götz <[email protected]> wrote:
> 
>> Ah ok, the patch didn't make it into the mailing list.
>> 
>> What I did is simply:
>> 
>> - AjaxRequestAttributes are created (and saved as a property) in
>> RequestCycle (in execute(…))
>> 
> 
> I don't like this. There is nothing specific to Ajax in RequestCycle so far
> and I'd like to keep it this way.

I agree. Although I tend to think that it would be relatively clean, without 
the need to introduce new Listener interfaces or other classes. And to me 
RequestCycle feels not that wrong to configure stuff like this ...

> 
> 
>> - IRequestCycleListener gets a new method:
>>  void updateAjaxAttributes(RequestCycle cycle, AjaxRequestAttributes
>> attributes)
>> 
> 
> With this change you'd have to wait for Wicket 7. No changes to APIs in
> minor versions!

Ok, wasn't thinking about that yet.

   -Tom

Reply via email to