Please file a ticket so I don't forget and I'll change it. Or you do it :-)
On Wed, May 22, 2013 at 5:01 PM, Sven Meier <s...@meiers.net> wrote: > Hi Martin, > > I'd say we should change it for 7.x only. > > For 6.x it's better to leave it STOP, since that corresponds to the > behavior before "eventPropagation" was introduced. > > Sven > > > On 05/22/2013 03:46 PM, Martin Grigorov wrote: > >> On Wed, May 22, 2013 at 4:41 PM, Sven Meier <s...@meiers.net> wrote: >> >> With Wicket 7.0.0 we will follow the jquery convention with >>> "preventDefault" initially set to false. >>> >>> @Martin: >>> Shouldn't ARA#eventPropagation set to BUBBLE initially? That would be >>> consistent with jquery too. >>> >> >> This is how it was in 6.7.0 and there were two users complaining about the >> changed behavior, so we reverted it in 6.8.0 to what it was till 6.6.0. >> Do others think that bubble should be the default ? >> >> >> >> >>> Sven >>> >>> >>> On 05/22/2013 03:34 PM, Nick Pratt wrote: >>> >>> Hi Martin >>>> >>>> I didnt mean to imply that we should change the functionality, just >>>> that I >>>> think we should follow the convention of whatever jquery/JS do, except >>>> in >>>> the cases where components need to alter this behavior for their correct >>>> functionality. So if the JS/jquery default is to allow event >>>> propagation, >>>> then Wicket should default to this same behavior, except where noted. >>>> >>>> N >>>> >>>> >>>> On Wed, May 22, 2013 at 8:44 AM, Martin Grigorov <mgrigo...@apache.org >>>> >>>>> wrote: >>>>> >>>> Hi Nick, >>>> >>>>> >>>>> On Wed, May 22, 2013 at 3:30 PM, Nick Pratt <nbpr...@gmail.com> wrote: >>>>> >>>>> With regards to the default setting of this value, I think we should >>>>> follow >>>>> >>>>> whatever jquery / JS does by default (I dont know whether this is the >>>>>> >>>>>> case >>>>> >>>>> or not). I think events propagate by default, so any provided >>>>>> components >>>>>> that need to alter this behavior should explicitly set (false) for >>>>>> this >>>>>> value. >>>>>> >>>>>> We need to prevent the default for AjaxFallback** components because >>>>>> >>>>> otherwise both the Ajax and the non-Ajax behaviors will be executed. >>>>> >>>>> We need to stop the propagation of the event by default because >>>>> otherwise >>>>> you may get more than one Ajax calls when you click on a link which is >>>>> inside a div which also has listener for 'click' (WICKET-5093). >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >
