Hi Martin,
unfortunately in this days I don't have much spare time and I can't do
much about Wicket. However I'm curious about what you intended to do
with MountMapper. IMHO the MountMapper should be inserted in the mappers
hierarchy as superclass of both MountedMapper and PackageMapper. It
should be in charge of storing the segments that compose the path they
are mounted at and it should also handle URL's parameters (both required
and optional). In this way PackageMapper would not be mounted anymore
wrapping it inside a MountMapper, but it will be used as an independent
mapper, just like we already do with MountedMapper.
The problem is that PackageMapper and MountedMapper are in the 'core'
module, while MountMapper is in the 'request' one. This makes inserting
the three mappers in the same hierarchy a little bit tricky.
Did you have an easier and more effective plan to refactor MountMapper?
On Fri, May 3, 2013 at 5:56 PM, Andrea Del Bene <[email protected]>wrote:
This issue was discussed also in WICKET-4686, right?
Yes.
Hi,
org.apache.wicket.request.**mapper.mount.MountMapper hasn't been
completely
finished in 1.5.0 and later it has been even ignored in other mappers.
They
(e.g. MountedMapper, PackageMapper) deal with parsing of required/optional
parameters by themselves.
Does someone want to improve this for Wicket 7.0 ?
I think it should be possible to preserve the API of MountedMapper and
PackageMapper. The user applications wont see the change but internally it
will become much more flexible.
