Hi, Experiment with it and if nothing breaks then apply the changes. If it is not something that you need in your application then I'd prefer to make the change only in master branch.
On Mon, Oct 21, 2013 at 12:16 PM, Andrea Del Bene <[email protected]>wrote: > Hi, > > at the moment is impossible to use Image component with inheritable > models. Method initModel is overridden to return null and the > constructor that takes in input just the component id is declared as > protected. It would be fine if we could inherit a model object and use > one of its string property to set the src attribute of the <img> tag. > Coudn't we make the protected constructor public and use the default > version of initModel? The comment inside initModel says that the method > is overridden to use "... a simple model, explicitly set, or use their > tag's src or value attribute". However, if we look at the code of method > LocalizedImageResource.setSrcAttribute, it doesn't seem necessary to > override initModel to achieve this result. >
