Martin, I cannot find where IRedirectListener#onRedirect is actually called except when page is visited via RedirectPage... So, to me is just a marker... Maybe making it not final might make sense as a page could do something when some other RedirectPage redirects to it?
On Thu, Feb 20, 2014 at 10:30 AM, Martin Grigorov <[email protected]>wrote: > Hi, > > I have the following patch here: > > -public abstract class Page extends MarkupContainer implements > IRedirectListener, IRequestablePage > +public abstract class Page extends MarkupContainer implements > IRequestablePage > { > /** True if the page hierarchy has been modified in the current > request. */ > private static final int FLAG_IS_DIRTY = FLAG_RESERVED3; > @@ -497,16 +497,6 @@ public abstract class Page extends MarkupContainer > implements IRedirectListener, > } > > /** > - * Redirect to this page. > - * > - * @see org.apache.wicket.IRedirectListener#onRedirect() > - */ > - @Override > - public final void onRedirect() > - { > - } > - > > > o.a.w.Page currently implements IRedirectListener but does nothing in > #onRedirect() and the method is final. > What is the idea here ? Maybe to forbid page specializations to use > IRedirectListener ?! > > With my patch there are no other implementations of IRedirectListener, so > we can remove it completely. Can you imagine a use case when IRL is needed > ? > > > Martin Grigorov > Wicket Training and Consulting > -- Regards - Ernesto Reinaldo Barreiro
