On Fri, Jul 18, 2014 at 11:05 AM, Sven Meier <[email protected]> wrote:
> Hi, > > 3.5) Improve the javadoc and deprecate the class too, so users know they > should move away from it. > I like this suggestion! > > My 2 cents > Sven > > > > On 07/18/2014 09:39 AM, Martin Grigorov wrote: > >> Hi, >> >> At >> https://issues.apache.org/jira/browse/WICKET-4904? >> focusedCommentId=14059918&page=com.atlassian.jira. >> plugin.system.issuetabpanels:comment-tabpanel#comment-14059918 >> Garret Wilson makes a good point that the name of DisabledLinkBehavior is >> probably a bit confusing. The name suggests that this is the recommended >> way to disable links. >> >> Here are my suggestions to improve this: >> 1) rename to Wicket6DisabledLinkBehavior + javadoc update explaining that >> this is how links were disabled in Wicket 6 >> 2) rename to LegacyDisabledLinkBehavior + javadoc update explaining that >> this is how links were disabled in Wicket 6 >> 3) javadoc update explaining that this is how links were disabled in >> Wicket >> 6 >> >> In case of 1) or 2) we will update the migration guide too. >> >> Other ideas ? >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> >
