-1 on changing this for Wicket 6.x. We don't know which user code might call that method.

+0 for Wicket 7.x

Sven

On 08/07/2014 04:34 PM, Martin Grigorov wrote:
This is the change I propose:
https://gist.github.com/martin-g/733b79321527219740db

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


On Thu, Aug 7, 2014 at 3:55 PM, Martin Grigorov <[email protected]>
wrote:

Hi,

A user asks at http://markmail.org/message/s262q4yc3ubymglr the question
in the subject.
The check for visibility is very old (before Git history's knowledge).
The check for enable is
https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commitdiff;h=0fd8b2555bce81d0a34e1414f432cd719a4bf6e0;hp=4c5a75dd8b57e6d048d55ae93b9509ffb0e0bfdc
but it is not linked to a ticket with more info about the problem.

Is it OK to move the checks to
org.apache.wicket.markup.html.form.Form#onFormSubmitted(org.apache.wicket.markup.html.form.IFormSubmitter)
and let the applications find the submitter even when it is set
invisible/disabled in the action phase (i.e. in their #onSubmit()) ?

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


Reply via email to