add an exclude for asm:4.2 and test Spring injection Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov
On Sun, Sep 21, 2014 at 11:16 PM, Martijn Dashorst < [email protected]> wrote: > And I found the first real discrepancy: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Wicket IoC common code 7.0.0-SNAPSHOT > [INFO] > ------------------------------------------------------------------------ > [INFO] > [INFO] --- maven-enforcer-plugin:1.3.1:enforce (default-cli) @ wicket-ioc > --- > [WARNING] > Dependency convergence error for org.ow2.asm:asm:4.2 paths to dependency > are: > > +-org.apache.wicket:wicket-ioc:7.0.0-SNAPSHOT > +-cglib:cglib:3.1 > +-org.ow2.asm:asm:4.2 > > and > > +-org.apache.wicket:wicket-ioc:7.0.0-SNAPSHOT > +-org.ow2.asm:asm-util:5.0.3 > +-org.ow2.asm:asm-tree:5.0.3 > +-org.ow2.asm:asm:5.0.3 > > As there is no newer version of cglib that depends on a newer version > of asm, what should we do? > > Martijn > > > On Sun, Sep 21, 2014 at 8:48 PM, Martin Grigorov <[email protected]> > wrote: > > +1 > > > > my only concern is that you will need to restructure the current pom.xml > > files and later a cherry-pick from 7 to 6 (or vise versa) may not work as > > easy as now. > > but this is still manageable > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Sun, Sep 21, 2014 at 9:40 PM, Martijn Dashorst < > > [email protected]> wrote: > > > >> At work we use this maven plugin to enforce coding conventions for our > >> POMs: > >> > >> https://github.com/ferstl/pedantic-pom-enforcers > >> > >> While a major pain in the behinds, it enforces a single coding style > >> for Maven POMs, for example a definitive ordering of dependencies, > >> plugins, detecting duplicate code from dependencies, etc. > >> > >> It would be quite a hassle to initially introduce this plugin, and > >> every change you make (was that a song by the Police?) will probably > >> trigger one of the pedantic enforcer rules. > >> > >> In my experience at €day job the hassle is worth the pain. > >> > >> WDYT? I'm willing to add the plugin and make it work for our projects > >> in wicket 6 and 7 branches. > >> > >> Martijn > >> > >> -- > >> Become a Wicket expert, learn from the best: http://wicketinaction.com > >> > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com >
