Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457202
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java
---
@@ -88,9 +87,9 @@
* Thrown if something goes wrong with upload
*/
public MultipartServletWebRequestImpl(HttpServletRequest request,
String filterPrefix,
- Bytes maxSize, String upload) throws FileUploadException
+ Bytes maxSize, Bytes fileMaxSize, String upload) throws
FileUploadException
--- End diff --
we will need a new constructor here because adding new parameters will
break the backward compatibility.
preserve the old constructor(s) and pass `null` as a value for
`fileMaxSize` to the new one(s)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
