Ok, maybe I can solve this. But the problems are more "fundamental": 1. Framework inconsistency: in one place such dependencies are resolved using one mechanism (IJavaScriptLibrarySettings), in the second using another one (webjars). 2. Circular dependency: framework (Wicket) should not depends on library (wicket-webjars) which depends on that framework.
-- Daniel On Wed, Dec 10, 2014 at 4:46 PM, Martin Grigorov <[email protected]> wrote: > Patches and/or Pull Requests are always welcome! > > Wicket-Bootstrap uses webjars and OSGi users haven't complaint so far. > On Dec 10, 2014 5:41 PM, "Daniel Stoch" <[email protected]> wrote: > >> If we want to allow the applications to use their own version of >> jquery.atmosphere.js why not to use the similar solution to >> IJavaScriptLibrarySettings? In my opinion a framework (Wicket) should >> not depends on library (wicket-webjars) which depends on that >> framework. I know that wicket-atmoshpere is still an experimental >> project, but maybe in a near future it will be a part of core - and >> then such dependency will be problematic. >> >> Beside of this I am using OSGi environment for our applications and I >> don't know are these dependencies (wicket-webjars, jquery-atmosphere >> webjar) distributed as OSGi bundles? >> So "All you have to do is to edit your pom.xml." is not enough :( >> >> -- >> Daniel >> >> >> On Wed, Dec 10, 2014 at 4:32 PM, Martin Grigorov <[email protected]> >> wrote: >> > Hi, >> > >> > The .js file is inside jquery.atmosphere.jar file. It is loaded as any >> > other package resource in Wicket. >> > Wicket Webjars is just a helper that knows how to find the JS file in a >> > webjar (see http://webjars.org). >> > >> > The benefit of using webjars is that now the application can use any >> > version of Atmosphere, not just the one Wicket-Atmosphere has been >> released >> > with. All you have to do is to edit your pom.xml. >> > On Dec 10, 2014 5:26 PM, "Daniel Stoch" <[email protected]> wrote: >> > >> >> Hi, >> >> >> >> I'm trying to upgrade Wicket to 6.18 and Atmosphere integration to >> >> 0.21. Unfortunately in WICKET-5674 a new dependency was added >> >> (de.agilecoders.wicket.webjars). Do we really need this dependency, >> >> maybe it can be optional. I don't want to add another external project >> >> to my app and I don't know how this works. >> >> >> >> Where is a jquery.atmosphere.js in wicket-atmosphere module (it was >> >> there up to Wicket 6.16)? Is it downloaded at runtime from the web? >> >> What if my users does not have an internet connection (eg. from >> >> security reasons)? >> >> >> >> -- >> >> Daniel >> >> >>
