Hi,

There are many people using #isLinkEnabled(). At least there were many
questions about it in the mailing lists.
I think we should override #renderHead()
at org.apache.wicket.ajax.markup.html.AjaxLink#newAjaxEventBehavior and
don't call super if the link is disabled.
Same for AjaxFallbackLink.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Mon, Jan 19, 2015 at 11:35 AM, Sven Meier <[email protected]> wrote:

> Hi again,
>
> I've noticed that AbstractLink#isLinkEnabled() is broken for Ajax links
> since Wicket 6.x:
>
> Yes, you can override #isLinkEnabled() to override #isEnabledInHierarchy()
> with true. But this does not have any effect on AjaxEventBehavior, it just
> doesn't register its event handler anyway.
>
> I'm not sure we should reintroduce this broken method in 7.
>
> Regards
> Sven
>
>
>
> On 15.01.2015 16:20, Sven Meier wrote:
>
>> Hi Sebastien,
>>
>> seems I removed that method in back-and-forth of WICKET-4904.
>>
>> I'll restore this functionality asap.
>>
>> Regards
>> Sven
>>
>>
>> On 15.01.2015 15:08, Sebastien wrote:
>>
>>> Hi devs,
>>>
>>> First of all, I would like to wish you an happy coding year! :)
>>>
>>> I see there is some changes in AbstractLink between 6 & 7, and I am
>>> wondering why #isLinkEnabled has been removed from there.
>>>
>>> I am in a use case where my container is disabled, but still I would like
>>> my child link is enabled. Even #isLinkEnabled was just an helper to
>>> isEnabledInHierarchy, it used to have the advantage to not being final,
>>> so
>>> I could override it and this would answer my usecase...
>>>
>>> Would you agree to restore it?
>>>
>>> Thanks a lot in advance,
>>> Sebastien.
>>>
>>>
>>
>

Reply via email to