The change is in 6.18.0. Putting it in the migration for Wicket 7.x may help only if the developer jumps from 6.17.0- to 7.x. This may happen but usually it is recommended to upgrade to the latest 6.x version before going to 7.x. I don't mind to add it in the "Behavior changes" section. Do you have an account for the Wiki ? If NOT, then please give me your CWIKI userid.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sat, Feb 21, 2015 at 9:12 AM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Maybe we should add it to the document of the migration guide as a hint? > > kind regards > > Tobias > > > Am 20.02.2015 um 21:13 schrieb Martin Grigorov <mgrigo...@apache.org>: > > > > Hi, > > > > You are too fast! 10 mails in 3 hours!!! Give us some time to react :-) > > > > There is another mail with the issue explained at : > > > http://mail-archives.apache.org/mod_mbox/wicket-dev/201411.mbox/%3CCAMomwMoQ-Ba9aY8-pxHYxHoQ3=mnvpnjpel2hzgj9mycwoh...@mail.gmail.com%3E > > > > Thank you, Tobias! > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Fri, Feb 20, 2015 at 9:36 PM, Bryan Holladay <holla...@longsight.com> > > wrote: > > > >> Tobias, > >> > >> Thanks for that quick investigation! It works! I'll close this ticket. I > >> hope this is documented somewhere other than the random comment in > >> http://wicketinaction.com/2012/11/uploading-files-to-wicket-iresource/ > >> (I > >> guess at the least this email and the jira ticket are archived) > >> > >> -Bryan > >> > >> On Fri, Feb 20, 2015 at 2:27 PM, Tobias Soloschenko < > >> tobiassolosche...@googlemail.com> wrote: > >> > >>> Ok, I found out. call this: > >>> > >>> multiPartRequest = > >> webRequest.newMultipartWebRequest(Bytes.megabytes(100), > >>> "ignored"); > >>> multiPartRequest.parseFileParts(); > >>> > >>> kind regards > >>> > >>> Tobias > >>> > >>> P.S.: Ticket can be closed then. :-) > >>> > >>>> Am 20.02.15 um 19:40 schrieb Bryan Holladay: > >>>> > >>>> done: https://issues.apache.org/jira/browse/WICKET-5839 > >>>> > >>>> > >>>> Is there some kind of hack or workaround that you can think of? I > don't > >>>> want to wait until 6.20.0 is released. > >>>> > >>>> Thanks, > >>>> Bryan > >>>> > >>>> On Fri, Feb 20, 2015 at 1:32 PM, Tobias Soloschenko < > >>>> tobiassolosche...@googlemail.com> wrote: > >>>> > >>>> Yep, it seems that the request is not filled with the post parameters > >>>>> anymore. > >>>>> > >>>>> Would you be so kind and file in a ticket? > >>>>> > >>>>> kind regards > >>>>> > >>>>> Tobias > >>>>> > >>>>> Am 20.02.15 um 19:02 schrieb Bryan Holladay: > >>>>> > >>>>> No problem, I was able to easily reproduce it with the simplest > >> submit > >>>>> > >>>>>> button: https://github.com/baholladay/wicketrequesterror > >>>>>> > >>>>>> All you need to do is click submit and you'll see the parameter > value. > >>>>>> Then > >>>>>> change the wicket version from 6.16.0 to 6.19.0 and rebuild and > click > >>>>>> submit and you'll see no value after clicking submit. > >>>>>> > >>>>>> Thanks, > >>>>>> Bryan > >>>>>> > >>>>>> On Fri, Feb 20, 2015 at 12:13 PM, Tobias Soloschenko < > >>>>>> tobiassolosche...@googlemail.com> wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>>> are you able to create a quickstart that shows up the problem? > >>>>>>> > >>>>>>> kind regards > >>>>>>> > >>>>>>> Tobias > >>>>>>> > >>>>>>> Am 20.02.15 um 17:47 schrieb Bryan Holladay: > >>>>>>> > >>>>>>> I'm trying to upgrade to 6.19.0 from 6.16.0 and one of my rest > >>>>>>> endpoints > >>>>>>> > >>>>>>> doesn't have access to the post parameters anymore. > >>>>>>>> > >>>>>>>> I mount a specific endpoint to a page: > >>>>>>>> > >>>>>>>> Application.java > >>>>>>>> > >>>>>>>> mountPage("/fileUpload", FileUploadRest.class); > >>>>>>>> > >>>>>>>> > >>>>>>>> and then look for the parameters in the page > >>>>>>>> > >>>>>>>> FileUploadRest extends WebPage{ > >>>>>>>> > >>>>>>>> public FileUploadRest(){ > >>>>>>>> final ServletWebRequest webRequest = (ServletWebRequest) > >>>>>>>> getRequest(); > >>>>>>>> MultipartServletWebRequest multiPartRequest = > >>>>>>>> webRequest.newMultipartWebRequest(Bytes.megabytes(100), > "ignored"); > >>>>>>>> String uuid = > >>>>>>>> multiPartRequest.getRequestParameters().getParameterValue("uuid"). > >>>>>>>> toString(); > >>>>>>>> ... > >>>>>>>> } > >>>>>>>> > >>>>>>>> This UUID parameter works fine in 6.16.0 but is always null in > >> 6.19.0. > >>>>>>>> This > >>>>>>>> is true for all parameters and the file passed in. I verified that > >> the > >>>>>>>> post > >>>>>>>> is sending the data (by looking at the developer Network tab in > >>>>>>>> chrome). > >>>>>>>> > >>>>>>>> Request Payload: > >>>>>>>> > >>>>>>>> ------WebKitFormBoundaryttKBVItmK4S1fZNP > >>>>>>>> > >>>>>>>> Content-Disposition: form-data; name="myAwesomeDropzone_hf_0" > >>>>>>>> ------WebKitFormBoundaryttKBVItmK4S1fZNP Content-Disposition: > >>>>>>>> form-data; > >>>>>>>> name="uuid" 4e238b39-478d-4938-8bc2-0416508b04c6 > >>>>>>>> ------WebKitFormBoundaryttKBVItmK4S1fZNP Content-Disposition: > >>>>>>>> form-data; > >>>>>>>> name="file"; filename="test4.pdf" Content-Type: application/pdf > >>>>>>>> > >>>>>>>> I've also tried using a Resource and mounting that instead of a > >>>>>>>> WebPage > >>>>>>>> by > >>>>>>>> following the stackoverflow suggestion [1], but got the same > results > >>>>>>>> where > >>>>>>>> no parameters were being passed through. > >>>>>>>> > >>>>>>>> What has changed since 6.16.0 that would cause this? Is there a > >> better > >>>>>>>> way > >>>>>>>> (example?) or a fix for this? > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> > >>>>>>>> Bryan > >>>>>>>> > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> http://stackoverflow.com/questions/17874695/wicket- > >>>>>>>> http-post-get-raw-data-from-servletrequest > >> >
