Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/118#discussion_r30408568
--- Diff:
wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java ---
@@ -275,110 +276,70 @@ public void setObject(String object)
* not be obtained from resource bundles that are held relative to a
particular component or
* page. However, for application that use only global resources then
this parameter may be
* null.
- * <p>
- * The model parameter is also optional and only needs to be supplied
if value substitutions are
- * to take place on either the resource key or the actual resource
strings.
- * <p>
- * The parameters parameter is also optional and is used for
substitutions.
*
* @param resourceKey
* The resource key for this string resource
* @param component
* The component that the resource is relative to
- * @param model
- * The model to use for property substitutions
- * @param parameters
- * The parameters to substitute using a Java MessageFormat
object
*/
- public StringResourceModel(final String resourceKey, final Component
component,
- final IModel<?> model, final Object... parameters)
+ public StringResourceModel(final String resourceKey, final Component
component)
--- End diff --
To make the migration easier I think it would be good to have one more
constructor:
`public StringResourceModel(final String resourceKey, final Component
component, final IModel<?> model)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
