Hi, I think it is safe to make the change.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Jun 12, 2015 at 12:40 PM, Martijn Dashorst < [email protected]> wrote: > Heya, > > I'm going through the pom in master and was wondering why we > reinvented the default Maven properties for compiler source/output. > Maven has defined those properties as "maven.compiler.source" and > "maven.compiler.target" but we override them as "mvn.build...." > > I'd like to keep our Maven usage as canonical as possible so we can > rely on the documentation of Maven and common idioms. Also I'd like to > remove as much settings as possible and having custom properties in > our POM makes that more difficult and our POM much longer. > > For example we can define: > > <properties> > <maven.compiler.source>1.7</maven.compiler.source> > <maven.compiler.target>1.7</maven.compiler.target> > ... > </properties> > > and just in our build section: > > <build> > <plugins> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-compiler-plugin</artifactId> > <version>3.3</version> > </plugin> > </plugins> > </build> > > Not sure if a version is necessary or if that needs to be put in the > <pluginManagement> section. > > Is there a specific reason to use the custom properties that I'm > unaware of? Will replacing them with the usual Maven properties break > scripts? > > Martijn > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com >
