Maybe we should expose an API to untouch a page?! This will solve the case in WICKET-5933.
Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Jul 7, 2015 at 10:56 AM, Emond Papegaaij <[email protected] > wrote: > I've reopened 5933, and I think the change should be reverted. The reason a > page is touched on retrieval is that there is no way to be sure the page > did > not change once it has been read from the page store. The user is free to > change the state of the page in whatever way he/she sees fit. Only a few of > those will mark the page dirty. > > Best regards, > Emond > > On Tuesday 07 July 2015 09:19:52 Sven Meier wrote: > > I'll take a look at the problem too. > > > > Sven > > > > On 06.07.2015 22:11, Martin Grigorov wrote: > > > Hi, > > > > > > While testing 7.0.0 I've noticed that ModalWindow example doesn't work > as > > > expected anymore. > > > Clicking on 'Close this window with result "OK"' link doesn't update > the > > > feedback label. > > > > > > The regression is caused by: WICKET-5933 > > > <https://issues.apache.org/jira/browse/WICKET-5933> Avoid > serialization of > > > untouched page after ajax request > > > > > > Wicket doesn't touch the page anymore and changing component member > > > (like > > > org.apache.wicket.examples.ajax.builtin.modal.ModalWindowPage#result) > > > doesn't trigger state change > > > (org.apache.wicket.Page#componentStateChanging) so the new value is > lost. > > > > > > I see no better solution than reverting WICKET-5933. > > > > > > Any other ideas? > > > > > > Martin Grigorov > > > Freelancer. Available for hire! > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > >
