I was working in an older workspace and this commit was still not pushed. I didn't remember closing the issue, so I rebased master and didn't see any conflicts, so pushing was the next thing on the list.
It was an oversight. Good catch. Martijn On Wed, Jul 8, 2015 at 4:30 PM, Martin Grigorov <[email protected]> wrote: > I've asked because I didn't want to revert/change someone else's commit > before asking him what was the intention. > > Martin Grigorov > Freelancer. Available for hire! > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Jul 8, 2015 at 5:18 PM, Andrea Del Bene <[email protected]> > wrote: > >> I've noted the same problem. I did some cleaning inside >> BaseWicketTester.clickLink(String, boolean), some if blocks were not >> required: >> >> http://git-wip-us.apache.org/repos/asf/wicket/diff/a241db57 >> >> Hi Martijn, >>> >>> Why did you make this change ? >>> There is already "else if (linkComponent instanceof IAjaxLink && isAjax)" >>> few lines above [1] that you added few weeks ago with WICKET-5900. >>> >>> The problem is that there is a broken test now: >>> >>> http://ci.apache.org/builders/wicket-master/builds/23/steps/compile/logs/stdio >>> >>> 1. >>> >>> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java#L1906 >>> >>> >>> Martin Grigorov >>> Freelancer. Available for hire! >>> Wicket Training and Consulting >>> https://twitter.com/mtgrigorov >>> >>> On Wed, Jul 8, 2015 at 2:03 PM, <[email protected]> wrote: >>> >>> >>> >> -- Become a Wicket expert, learn from the best: http://wicketinaction.com
