Hi, I like the new look & feel !
But I do not like very much the idea to mix core & quickstart into core... More precisely: Having a QuickStartPage can makes sense (in a quickstart package for instance) but having WebApplication that reference/use/test QuickStartPage.class, I do like less. I would prefer having a QuickStartApplication that would have following signature: protected abstract Class<? extends QuickStartPage> getHomePage()... Just to be sure: we will still provide the quickstart archetype, it just will use the newly created classes and embedded style, right? Thanks & best regards, Sebastien. On Wed, Aug 12, 2015 at 12:51 PM, Martin Grigorov <[email protected]> wrote: > We can rename HomePage to QuickstartPage. > This way the developer can just throw away that page and start creating new > ones (e.g. HomePage). > Having both HomePage and QuickstartPage is another option. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Aug 12, 2015 at 12:50 PM, Joachim Rohde < > [email protected]> wrote: > > > Can't we have rather two different quickstarts? One for beginners to toy > > around and one bare one (without any components, markup, etc.) for people > > who already know Wicket? > > I guess for a beginner your proposal is quite confusing, so I'm not very > > fond of the idea to render a page which comes from wicket-core. > > > > But thumbs up for the new design. > > > > Joachim > > > > > > On 08/12/2015 09:39 AM, Martin Grigorov wrote: > > > >> Hi, > >> > >> I am not sure I like the idea. > >> The quickstart shows how to use the simplest Wicket component - Label. > >> If the demo page is plain HTML then a newbie will scratch her head > asking > >> what kind of magic happens here. > >> > >> I've never heard of a single complain about the quickstart page. > >> I have heard about complains how old fashioned the site and the examples > >> are though. The site is refreshed! Thanks, Martijn! > >> I'd love to see the examples with a new face! > >> > >> Martin Grigorov > >> Wicket Training and Consulting > >> https://twitter.com/mtgrigorov > >> > >> On Wed, Aug 12, 2015 at 10:25 AM, Rob Audenaerde < > >> [email protected]> > >> wrote: > >> > >> Hi Martijn, > >>> > >>> I was always annoyed by the fact that I had to search for the > >>> wicket-components in the HTML to remove (especially the page title) , > so > >>> I > >>> think it is a good idea to remove them. > >>> > >>> I don't see the benefit of a self-destructing message (makes it > >>> needlessly > >>> complex?), except from the humor :) > >>> > >>> -Rob > >>> > >>> On Wed, Aug 12, 2015 at 1:26 AM, Martijn Dashorst < > >>> [email protected]> wrote: > >>> > >>> I'm working on a new design for our quick start archetype and was > >>>> thinking about changing how the quick start renders the home page. > >>>> > >>>> For an idea of the new quick start page: > http://i.imgur.com/slwlCfX.png > >>>> > >>>> I've never liked that a user needs to remove the home page markup and > >>>> component from the HomePage class and html file. I'd rather have them > >>>> be skeletons. > >>>> > >>>> So my thinking is to ship wicket-core with a quick start home page > >>>> (with inline styling and assets), and reference that from > >>>> WicketApplication in the getHomePage() method, something like: > >>>> > >>>> @Override > >>>> protected Class<? extends WebPage> getHomePage() > >>>> { > >>>> if(QuickStartWelcomePage.isFirstRender()) > >>>> { > >>>> return QuickStartWelcomePage.class; > >>>> } > >>>> return HomePage.class > >>>> } > >>>> > >>>> And have QuickStartWelcomePage write a marker file to the container's > >>>> temp folder for which the isFirstRender() tests its existence for > >>>> determining if the welcome page was first rendered. After the first > >>>> render, the quick start will just render the empty page. > >>>> > >>>> The QuickStartWelcomePage can then be I18N and provide a welcome in > >>>> the locale of the user starting the app, and these I18N files won't > >>>> encumber the quick start package. > >>>> > >>>> The quick start it self can then just consist of 4 Java classes: > >>>> Start, HomePage, HomePageTest and WicketApplication, 1 HTML file, the > >>>> web.xml file and pom.xml. These files can be the absolute minimum > >>>> without any embellishments (other than the getHomePage() > >>>> implementation. > >>>> > >>>> WDYT? > >>>> > >>>> Martijn > >>>> > >>>> > >>>> > >>>> -- > >>>> Become a Wicket expert, learn from the best: > http://wicketinaction.com > >>>> > >>>> > >>> > >> >
