Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/142#discussion_r43583441
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResourceReference.java
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.wicket.request.resource.IResource;
+import org.apache.wicket.request.resource.ResourceReference;
+
+/**
+ * This resource reference is used to provide a reference to a resource
based on Java NIO FileSystem
+ * API.<br>
+ * <br>
+ * To implement a mime type detection refer to the documentation of
+ * {@link java.nio.file.Files#probeContentType(Path)} and provide an
implementation for
+ * java.nio.file.spi.FileTypeDetector in the META-INF/services folder for
jars or in the
+ * /WEB-INF/classes/META-INF/services folder for webapps<br>
+ * <br>
+ * You can optionally override {@link #getMimeType()} to provide an inline
mime type detection,
+ * which is preferred to the default detection.<br>
+ * <br>
+ * Example:
+ *
+ * <pre>
+ * <code>
+ * Path path =
FileSystemResourceReference.getPath(URI.create("jar:file:///folder/file.zip!/folderInZip/video.mp4"));
+ * add(new Video("video", new FileSystemResourceReference(path)));
+ * </code>
+ * </pre>
+ *
+ * @author Tobias Soloschenko
+ */
+public class FileSystemResourceReference extends ResourceReference
+{
+ private static final long serialVersionUID = 1L;
+
+ private Path path;
+
+ private static Map<URI, FileSystem> fileSystemURIs = new HashMap<URI,
FileSystem>();
+
+ /**
+ * Creates a file system resource reference based on the given path
+ *
+ * @param name
+ * the name of the resource reference to expose data
+ * @param path
+ * the path to create the resource reference
+ */
+ public FileSystemResourceReference(String name, Path path)
+ {
+ super(name);
+ this.path = path;
+ }
+
+ /**
+ * Creates a file system resource reference based on the given path
+ *
+ * @param path
+ * the path to create the resource reference (the name is
used to expose the data)
+ */
+ public FileSystemResourceReference(Path path)
+ {
+ super(path.getFileName().toString());
+ this.path = path;
+ }
+
+ /**
+ * Creates a new {@link
org.apache.wicket.markup.html.media.FileSystemResource} and applies the
+ * path to it.
+ */
+ @Override
+ public IResource getResource()
+ {
+ return getFileSystemResource();
+ }
+
+ /**
+ * Used to apply a custom mime type without implementing a mime type
detection
+ *
+ * @return the mime type
+ * @throws IOException
+ * if the mime type could'nt be read
+ */
+ protected String getMimeType() throws IOException
+ {
+ return getFileSystemResource().getMimeType();
+ }
+
+ /**
+ * Gets the file system resource to be used for the resource reference
+ *
+ * @return the file system resource to be used for the resource
reference
+ */
+ protected FileSystemResource getFileSystemResource()
+ {
+ return new FileSystemResource(path);
+ }
+
+ /**
+ * Creates a path and a file system (if required) based on the given URI
+ *
+ * @param uri
+ * the URI to create the file system and the path of
+ * @param env
+ * the environment parameter to create the file system with
+ * @return the path of the file in the file system
+ * @throws IOException
+ * if the file system could'nt be created
+ * @throws URISyntaxException
+ * if the URI has no valid syntax
+ */
+ public static Path getPath(URI uri, Map<String, String> env) throws
IOException,
+ URISyntaxException
+ {
+ String uriString = uri.toString();
+ int indexOfExclamationMark = uriString.indexOf('!');
+ if (indexOfExclamationMark == -1)
+ {
+ return Paths.get(uri);
+ }
+ String zipFile = uriString.substring(0, indexOfExclamationMark);
+ FileSystem fileSystem = fileSystemURIs.get(uri);
+ if (fileSystem == null)
+ {
+ if (env == null)
+ {
+ env = new HashMap<>();
+ env.put("create", "true");
+ env.put("encoding", "UTF-8");
+ }
+ fileSystem = FileSystems.newFileSystem(new
URI(zipFile), env);
+ fileSystemURIs.put(uri, fileSystem);
--- End diff --
What is the reason of the caching of the file systems here?
It has some issues related to concurrency. Better use ConcurrentMap with
`#putIfAbsent()`.
I'd prefer if Wicket doesn't cache it though. I can foresee some issues
with redeployments and OSGi usage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
