On 10/11/2015 09:45, Martin Grigorov wrote:
On Mon, Nov 9, 2015 at 10:42 PM, <[email protected]> wrote:

+               if (body.getId().equals(replacement.getId()))

Why not identity check as the other places?

This may fail if there are two Borders with the same id in the hierarchy.
Very unlikely to replace their bodies though.
Good point. Initially it was an identity check as the others, but then I thought that in this case it might not have sense. With an identity check we are telling something like "replace body with...itself?". So I thought that checking for the same body's id is more rational. But as you said it's very unlikely that somebody will replace body component....
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


Reply via email to