Looks safe. But please amend your commit so that its message mentions the ticket number when you merge it to Apache Git. Thanks!
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sat, Jan 2, 2016 at 8:49 PM, Andrea Del Bene <[email protected]> wrote: > Hi, > > lately I've spent some time on PackageResource's code while I was > debugging a problem with a web app. The problem was in my business code but > I think I've found something that might improve the code and the > performance of PackageResource. Method 'getCacheKey' (which is called > multiple times) indirectly calls internalGetResourceStream to check if > package resource exists, but for this purpose we should use static method > 'exists' which is lighter than internalGetResourceStream. > I prepared a commit with this change in my GitHub fork: > https://github.com/bitstorm/wicket/commit/1d75071124d919410d1144911a80cd871ae1325b > > WDYT? > > Andrea. >
