I think because it is not required I would not add it (it also slows down a bit)
kind regards Tobias > Am 25.01.2016 um 17:25 schrieb Sven Meier <[email protected]>: > > Well, shouldn't it be disabled again after the script has finished? > > At least because of *symmetry*? > > Sven > > >> On 25.01.2016 17:16, Tobias Soloschenko wrote: >> Hi Sven, >> >> it stays online as long as the script thread lifes to ensure the security >> the whole time the script is executed. (ThreadLocal) >> >> kind regards >> >> Tobias >> >>> Am 25.01.2016 um 17:12 schrieb Sven Meier <[email protected]>: >>> >>> Hi Tobias, >>> >>> the securityManager is never disabled again, is this intended? >>> >>> I find this lack of symmetry disturbing ;) >>> >>> Sven >>> >>>> On 25.01.2016 16:21, Tobias Soloschenko wrote: >>>> Hi, >>>> >>>> hope that everthing is ok with nashorn-parent. :-) >>>> >>>> I think I have committed everything to ensure the maximum safety to run >>>> the script engine (MemoryLeakDetection, ClassFilter, prevention for >>>> endless running script, SecurityManager which can be enabled only for the >>>> script threads) >>>> >>>> Anyway don't use it as public interface! >>>> >>>> I would be very pleased if someone could review it in detail before >>>> release of wicketstuff 7.2.0. >>>> >>>> Again thanks a lot to Martin Grigorov who mentioned some points to fix. >>>> >>>> kind regards >>>> >>>> Tobias >>>> >>>>> Am 25.01.2016 um 15:22 schrieb Martin Grigorov <[email protected]>: >>>>> >>>>> Hi, >>>>> >>>>> I'm going to release WicketStuff 7.2.0 in the next few days. >>>>> Please commit your improvements now! Or wait for 7.3.0 :-) >>>>> >>>>> Martin Grigorov >>>>> Wicket Training and Consulting >>>>> https://twitter.com/mtgrigorov >
