Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-192903071
There are some problems with the PR.
Initially its single unit test was failing.
I've fixed it by using again TesterBroadcaster.
Now deployment at Tomcat 8.x fails with:
```
java.lang.NullPointerException
org.atmosphere.handler.ReflectorServletProcessor.loadServlet(ReflectorServletProcessor.java:104)
org.atmosphere.handler.ReflectorServletProcessor.loadWebApplication(ReflectorServletProcessor.java:84)
org.atmosphere.handler.ReflectorServletProcessor.init(ReflectorServletProcessor.java:172)
org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1732)
org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1721)
org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:917)
org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:838)
org.atmosphere.cpr.AtmosphereFrameworkInitializer.configureFramework(AtmosphereFrameworkInitializer.java:75)
org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:84)
org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:80)
org.atmosphere.cpr.AtmosphereServlet.init(AtmosphereServlet.java:75)
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:610)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:516)
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1086)
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:659)
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1558)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1515)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
java.lang.Thread.run(Thread.java:745)
```
Please take a look at branch
https://github.com/apache/wicket/tree/pr-160-master and commit
https://github.com/apache/wicket/commit/ebfa1bb3381b187b704b0170b742f06ad2b84c24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
