Hi Kostas, I've sent you an invitation! Thank you for helping us!
As Ernesto said you can still send Pull Requests if you want a second pair of eyes on your changes. You can merge yours and others people PRs when you believe that the code brings improvement. master branch is used for WicketStuff 7.x. If you need your changes in WicketStuff 6.x then you'll need to merge them to wicket-6.x branch. Or just ask someone else to help with that. Have fun! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 23, 2016 at 7:52 AM, Ernesto Reinaldo Barreiro < [email protected]> wrote: > Normally there are some people reviewing PRs and merging them. I do have > commit access but never commit directly to the project. I create PRs, as > you did, and wait for them to be merged. > > On Tue, Mar 22, 2016 at 9:43 PM, Kostas Karavitis <[email protected]> > wrote: > > > Hello, > > > > I would like to have commit access for wicketstuff project. My github > > username is kkaravitis. > > > > I made changes on wicketstuff portlet and I managed to make the > wicketstuff > > portlet bridge functional. > > I tested the wicket 7.x examples as portlets succesfully on the following > > enviroments: > > > > - websphere portal 8.5 > > - liferay 6.1 GA3 > > - liferay 6.2 GA6 > > > > Please look also at my pull request > > https://github.com/wicketstuff/core/pull/476 > > > > > > -- > Regards - Ernesto Reinaldo Barreiro >
