Just moments after sending the mail I recalled that DropWizard provides
something similar:
https://dropwizard.github.io/metrics/3.1.0/manual/servlets/
So there is no need of a custom IResource.
We just have to make it easier to lookup the MetricsRegistry from
MetricsServlet - via the ServletContext.

I wonder whether the ServletContext solution could be used instead of the
Application#get(String) and static variable fallbacks. I.e. somehow to get
a reference to ServletContext in Session#onInvalidate().

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Mar 25, 2016 at 10:48 PM, Martin Grigorov <[email protected]>
wrote:

> Hi Tobias,
>
> Inspired by
> https://github.com/jooby-project/jooby/tree/master/jooby-metrics I think
> it would be nice if wicket-metrics provides a IResource that renders JSON
> with the current metrics per type/aspect.
> I.e. if /wicket/metrics/ is requested then it dumps something like:
>
> {
>   "SomeTimerAspect" : {min:.., max:..., mean:..., ...},
>   ...
>    "SomeCounterAspect" : {value:..},
>    ...
> }
>
> When /wicket/metrics/SomeCounterAspect is requested then :
> {"value": ...}
> is rendered.
>
> Do you think it is a good idea ?
>
> It will be useful for quicker checks of the current state.
>
> The application will have to mount it explicitly in MyApp#init().
>
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>

Reply via email to