Good! Please close the PR because we don't have permissions to do it ourselves.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Apr 29, 2016 at 4:04 PM, nino martinez wael < [email protected]> wrote: > Im sorry to have wasted your time, it seems to be something related to > PAX wicket..! > > > Keep up the good working WICKETING :) > > On Fri, Apr 29, 2016 at 3:08 PM, nino martinez wael > <[email protected]> wrote: > > I know, but it's seems to be some kind of dynamic dependency.. > > > > Let me check if it's something pax wicket introduces somehow, it of > > course could also be a transitive dependency... > > > > On Fri, Apr 29, 2016 at 2:54 PM, Martin Grigorov <[email protected]> > wrote: > >> As you can see in wicket-core/pom.xml there is no dependency to cglib, > so I > >> am not sure why Karaf reports such dependency. > >> > >> Martin Grigorov > >> Wicket Training and Consulting > >> https://twitter.com/mtgrigorov > >> > >> On Fri, Apr 29, 2016 at 2:12 PM, nino martinez wael < > >> [email protected]> wrote: > >> > >>> HMMM, I've debugged at bit > >>> > >>> heres the bundle wicket-core when loaded in karaf 4.0.5 > >>> > >>> https://paste.apache.org/Bpzc > >>> > >>> line 114-116 states cglib are used in wicket core. > >>> > >>> luckily, but confusing, for my test right now it works because only > >>> cglib ~2.x are present, stuff goes wrong when a version higher are > >>> present because cglib 2 and 3 are not compatible. > >>> > >>> I cannot bump cglib versions in PAX-Wicket, because I will loose > >>> backwards compability plus it's out of scope for this release (which > >>> primary are to get wicket 6.x to work with karaf 4.x). > >>> > >>> PAX-WICKET does not use wicket-ioc.. > >>> > >>> regards Nino > >>> > >>> > >>> > >>> On Fri, Apr 29, 2016 at 12:41 PM, nino martinez wael > >>> <[email protected]> wrote: > >>> > I will continue in this thread then. > >>> > > >>> > I will debug and find the culprit, when I added the osgi imports to > >>> > wicket core, there where no longer problems. > >>> > > >>> > On Fri, Apr 29, 2016 at 12:14 PM, Martin Grigorov < > [email protected]> > >>> wrote: > >>> >> Hi, > >>> >> > >>> >> On Fri, Apr 29, 2016 at 11:48 AM, nino martinez wael < > >>> >> [email protected]> wrote: > >>> >> > >>> >>> Hi > >>> >>> > >>> >>> I just asked if you could pull a minor change so that wicket again > >>> >>> will work with pax wicket.. Any horizon on when that will happend. > >>> >>> > >>> >> > >>> >> As soon as we are convinced that the change is good. > >>> >> So far I am not convinced. > >>> >> You added OSGi related dependencies to a Maven module that doesn't > use > >>> >> these dependencies at all. > >>> >> > >>> >> P.S. Do not start several mail threads for the same topic! > >>> >> > >>> >> > >>> >>> > >>> >>> -- > >>> >>> Best regards / Med venlig hilsen > >>> >>> Nino Martinez > >>> >>> > >>> > > >>> > > >>> > > >>> > -- > >>> > Best regards / Med venlig hilsen > >>> > Nino Martinez > >>> > >>> > >>> > >>> -- > >>> Best regards / Med venlig hilsen > >>> Nino Martinez > >>> > > > > > > > > -- > > Best regards / Med venlig hilsen > > Nino Martinez > > > > -- > Best regards / Med venlig hilsen > Nino Martinez >
