Hi Pedro, There were no complains about the current parser, but that doesn't mean we should not improve!
Two questions: 1) can it be switchable? i.e. if someone faces a problem with the new parser then by using a JVM setting (-Dxyz=...) to switch to the old parser 2) does it cover all current funtionality ? I don't use fancy property expressions in my apps but I remember seeing support for array and list indexing. Your branch talks about map keys but since the syntax is the same maybe it is already supported. But if it is then the index should be parsed to int at the usage side. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Sep 21, 2016 at 2:30 AM, Pedro Santos <pedros...@gmail.com> wrote: > Hi devs, > > currently we can't have expression properties for map keys containing the > '[' character, even though it's a valid key character. My proposal is to > change our current string literal to a quoted one. So the expression > *map[myKey]* would no longer be valid in benefit of *map["myKey"]* or > *map['myKey']*. Any quote and escape character would need to be escaped, > and I suggest us to use the same escape logic from the Unified Expression > Language [1] and the original OGNL[2]. > > 1 - http://docs.oracle.com/javaee/5/tutorial/doc/bnahq.html#bnahu > 2 - http://commons.apache.org/proper/commons-ognl/language-guide.html > > cheers > > Pedro Santos >
