We can argue whole day... There is no perfect software... Is there a good reason to use "protected final" ? Google "Wicket final modifier" and you will see a lot of complains by users. I know that methods and classes should be final sometimes. Please convince us this is one of those cases.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Sep 27, 2016 at 3:18 PM, Emond Papegaaij <[email protected] > wrote: > No, adding new methods is also allowed (public or protected). If adding a > new > final method is considered an API break, adding a new non-final method > must be > considred an API break as well. Suppose you have the following method in a > subclass: > > protected String myMethod() {} > > And I add the following non-final method to a superclass: > > public Integer myMethod() {} > > This breaks twice. > > Best regards, > Emond > > On dinsdag 27 september 2016 14:59:40 CEST Martin Grigorov wrote: > > Hi Emond, > > > > It is considered as API break because a sub-class may already have this > > method and 'final' would break it. > > Is it OK to remove the 'final's ? > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Tue, Sep 27, 2016 at 2:51 PM, Emond Papegaaij < > [email protected] > > > wrote: > > > > > > On dinsdag 27 september 2016 14:17:37 CEST Martin Grigorov wrote: > > > > Fixed! > > > > > > > > It seems the backport from 8.x (master) broke it. > > > > The generics are fine with JDK 8. > > > > > > > > But now there is broken Clirr because of Csrf request cycle listener > > > > > > This is a bug in Clirr, which I think I fixed. A private methode has > > > become > > > protected final, this is NOT an API change. I tried adding it to the > > > whitelist. I do not have the time to look at this at the moment, > perhaps > > > someone else can have a look? > > > > > > Best regards, > > > Emond > > > > > > > Martin Grigorov > > > > Wicket Training and Consulting > > > > https://twitter.com/mtgrigorov > > > > > > > > On Tue, Sep 27, 2016 at 2:07 PM, Martijn Dashorst < > > > > > > > > [email protected]> wrote: > > > > > In ApplicationSettings this fails. Both in Eclipse and maven. > > > > > > > > > > Martijn > > > > > > > > > > -- > > > > > Become a Wicket expert, learn from the best: > http://wicketinaction.com > > >
