Any opinions? I can re-run the release just as easily. Martijn
On Sat, Oct 8, 2016 at 9:45 AM, Martijn Dashorst <[email protected]> wrote: > I don't mind either way. The release train is stalled due to laptop problems > (rogue antivirus enabling a firewall apparently), so I didn't get around to > preparing 7 and 8. > > Martijn > > > On Friday, 7 October 2016, Martin Grigorov <[email protected]> wrote: >> >> What's the status here ? >> Shall we release or rebuild ? >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Thu, Sep 29, 2016 at 1:56 PM, Martin Grigorov <[email protected]> >> wrote: >> >> > Hi, >> > >> > IMO it is OK to release with this bug. >> > Most of the new apps probably would use latest 7.x instead of 6.x. >> > >> > Martin Grigorov >> > Wicket Training and Consulting >> > https://twitter.com/mtgrigorov >> > >> > On Thu, Sep 29, 2016 at 6:47 AM, Pedro Santos <[email protected]> >> > wrote: >> > >> >> As we updated our Jetty dependency version from 7.6.13.v20130916 to >> >> 7.6.21.v20160908 [1], we unfortunately broke our quickstart's >> >> jetty-maven-plugin since this new version is not released under the old >> >> Jetty host Mortbay [2], as configured in our quickstart pom.xml. >> >> Actually >> >> I >> >> can't find this plugin version even in the new Jetty host releases [3]. >> >> >> >> Given that the quickstart is the entry point for new developers in >> >> Wicket, >> >> and that I don't know how common is this plugin usage ( I use it to >> >> start >> >> wicket-examples ), I'm -0 to release this version. >> >> >> >> On another topic, the pom.xml's version in the build/wicket-6.25.0 >> >> branch >> >> is 6.26.0-SNAPSHOT. Is it OK? Even the wicket-examples site is showing >> >> me 6.26.0-SNAPSHOT. >> >> >> >> Cheers >> >> >> >> 1 - >> >> https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=blo >> >> bdiff;f=archetypes/quickstart/src/main/resources/archetype- >> >> resources/pom.xml;h=2afc43303ce865479144e2ec35b7efcf41c1450b >> >> ;hp=07e39fd9955d1d673fbb66f5fa8110fcd4eacb09;hb=52f0b8af; >> >> hpb=6ec87eeba13500b89b6c81c757d8a946c68e8222 >> >> 2 - >> >> https://repo.maven.apache.org/maven2/org/mortbay/jetty/jetty >> >> -maven-plugin/ >> >> 3 - >> >> https://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty >> >> -maven-plugin/ >> >> >> >> Pedro Santos >> >> >> >> On Tue, Sep 27, 2016 at 6:43 AM, Andrea Del Bene <[email protected]> >> >> wrote: >> >> >> >> > +1 Built and tested random examples >> >> > >> >> > >> >> > >> >> > On 26/09/2016 17:11, Sven Meier wrote: >> >> > >> >> >> +1 release 6.25.0 >> >> >> >> >> >> Built, checked md5 and poked some examples. >> >> >> >> >> >> Thanks >> >> >> Sven >> >> >> >> >> >> >> >> >> On 24.09.2016 15:22, Martijn Dashorst wrote: >> >> >> >> >> >>> This is a vote to release Apache Wicket 6.25.0 >> >> >>> >> >> >>> Please download the source distributions found in our staging area >> >> >>> linked below. >> >> >>> >> >> >>> I have included the signatures for both the source archives. This >> >> >>> vote >> >> >>> lasts for 72 hours minimum. >> >> >>> >> >> >>> [ ] Yes, release Apache Wicket 6.25.0 >> >> >>> [ ] No, don't release Apache Wicket 6.25.0, because ... >> >> >>> >> >> >>> Distributions, changelog, keys and signatures can be found at: >> >> >>> >> >> >>> https://dist.apache.org/repos/dist/dev/wicket/6.25.0 >> >> >>> >> >> >>> Staging repository: >> >> >>> >> >> >>> https://repository.apache.org/content/repositories/orgapache >> >> wicket-1074/ >> >> >>> >> >> >>> The binaries are available in the above link, as are a staging >> >> >>> repository for Maven. Typically the vote is on the source, but >> >> >>> should >> >> >>> you find a problem with one of the binaries, please let me know, I >> >> >>> can >> >> >>> re-roll them some way or the other. >> >> >>> >> >> >>> Staging git repository data: >> >> >>> >> >> >>> Repository: [email protected]:dashorst/wicket.git >> >> >>> Branch: build/wicket-6.25.0 >> >> >>> Release tag: rel/wicket-6.25.0 >> >> >>> >> >> >>> >> >> >>> ============================================================ >> >> ============ >> >> >>> >> >> >>> The signatures for the source release artefacts: >> >> >>> >> >> >>> >> >> >>> Signature for apache-wicket-6.25.0.zip: >> >> >>> >> >> >>> -----BEGIN PGP SIGNATURE----- >> >> >>> Comment: GPGTools - https://gpgtools.org >> >> >>> >> >> >>> iEYEABECAAYFAlfmfCEACgkQJBX8W/xy/UXaZACdFBqxuvFcai65YtX+tWD09OEy >> >> >>> AxkAnA9PUgDJQL+0iV23RK6FbLRJCEoZ >> >> >>> =issT >> >> >>> -----END PGP SIGNATURE----- >> >> >>> >> >> >>> Signature for apache-wicket-6.25.0.tar.gz: >> >> >>> >> >> >>> -----BEGIN PGP SIGNATURE----- >> >> >>> Comment: GPGTools - https://gpgtools.org >> >> >>> >> >> >>> iEYEABECAAYFAlfmfCEACgkQJBX8W/xy/UUUgQCfUbwPNEK3DW+EoyJE2ukoCjgF >> >> >>> CPYAnRk58qx7E4s0PlWDEVW2Y+c08LcZ >> >> >>> =kttX >> >> >>> -----END PGP SIGNATURE----- >> >> >>> >> >> >>> ============================================================ >> >> ============ >> >> >>> >> >> >>> CHANGELOG for 6.25.0: >> >> >>> >> >> >>> ** Sub-task >> >> >>> >> >> >>> * [WICKET-6218] - backport fix for WICKET-6172 to Wicket 6.x >> >> >>> >> >> >>> ** Bug >> >> >>> >> >> >>> * [WICKET-5972] - Datepicker "Close" text overlays 'x' icon. >> >> >>> * [WICKET-6136] - AutoCompleteTextField issue in Android 5.1.1 >> >> >>> * [WICKET-6209] - requesting focus on disabled field fails >> >> >>> with >> >> >>> error in IE8 >> >> >>> * [WICKET-6214] - ModalWindow broken on IE >> >> >>> * [WICKET-6219] - Fragment fails to report an error in >> >> development >> >> >>> mode >> >> >>> * [WICKET-6225] - Button wrongly sets its model object as >> >> >>> 'value' >> >> >>> attribute >> >> >>> * [WICKET-6227] - CharSequenceResource calculates wrong length >> >> >>> when there are unicode symbols >> >> >>> * [WICKET-6230] - Infinite redirection when using >> >> >>> UrlPathPageParametersEncoder >> >> >>> * [WICKET-6232] - When sending binary data from server to >> >> >>> client, >> >> >>> wicket-websocket-jquery.js throws error "message.indexOf is not a >> >> >>> function" >> >> >>> * [WICKET-6235] - TableTree#updateNode() fails if no >> >> corresponding >> >> >>> node is visible >> >> >>> * [WICKET-6236] - Files.remove() causes a 5 seconds delay >> >> >>> instead >> >> >>> of 500ms as was intended >> >> >>> * [WICKET-6237] - PageRequestHandlerTracker doesn't work with >> >> >>> IRequestHandlerDelegate >> >> >>> * [WICKET-6245] - Open up CsrfPreventionRequestCycleListener >> >> >>> for >> >> >>> extension >> >> >>> * [WICKET-6246] - WebSocket request while Ajax request leads >> >> >>> to >> >> >>> error regarding HtmlHeaderCotnainer >> >> >>> >> >> >>> ** Improvement >> >> >>> >> >> >>> * [WICKET-6206] - Allow to use custom anticache parameter >> >> >>> value >> >> >>> for Image component >> >> >>> * [WICKET-6210] - FileUpload does not support files of zero >> >> >>> size >> >> >>> * [WICKET-6226] - DOCTYPE URL in properties.xml example in >> >> wicket >> >> >>> documentation won't work. >> >> >>> * [WICKET-6233] - Add component info in the error messages >> >> related >> >> >>> to WicketTester#assertComponentOnAjaxResponse() >> >> >>> * [WICKET-6234] - Log the decrypted url in CryptoMapper for >> >> >>> debugging purposes >> >> >>> * [WICKET-6239] - Use Response#addHeader() instead of >> >> >>> #setContentLength() >> >> >>> >> >> >> >> >> >> >> >> > >> >> >> > >> > > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com > -- Become a Wicket expert, learn from the best: http://wicketinaction.com
