[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....

[klopfdreh]

Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/193#discussion_r89677866
  
    --- Diff: pom.xml ---
    @@ -447,6 +447,12 @@
                                <type>jar</type>
                        </dependency>
                        <dependency>
    +                   <groupId>com.tdunning</groupId>
    +                   <artifactId>json</artifactId>
    +                           <version>1.2-SNAPSHOT</version>
    --- End diff --
    
    Hi @bitstorm ,
    
    1.2 has been just released. 😄 
    
    Anyway the were two reasons why to wait for this version.
    
    1. The slash / should only be escaped after a "<" bracket 
(https://github.com/tdunning/open-json/commit/e1541126bf3206fa7a2b243f3791e274822128c1)
    2. JSONFunction was not implemented yet. 
(https://github.com/tdunning/open-json/commit/174ab93ac966f0213ac4a4bd3ac5b17e0920a7c8)
 - this is required for json like this: { "mykey": window.myfunction() }
    
    We can switch the version to 1.2 and it should work with this PR.
    
    kind regards
    
    Tobias


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---