OK :) Thanks! On Thu, Feb 2, 2017 at 4:02 PM, Sebastien <[email protected]> wrote:
> Hi Maxim, > > Of course if a plugin is not a jQuery plugin, that may be strange that it > will be in the "Wicket jQuery UI" API... Also, I'm suspecting you are the > only one project that use it ;) > > I can deprecate it in 6.x/7.x/8-Mx so people will be aware in the next > release and can protest before it is too late... > Please note that if I remove it, I need to remove it in all branches (I > know I'm not semver, but I would like to keep branches strictly aligned for > the sake of my sanity ;)) > > I'm +1 to remove, let's see what folks are thinking... > > > > On Thu, Feb 2, 2017 at 9:41 AM, Maxim Solodovnik <[email protected]> > wrote: > > > Hello Sebastien, > > > > Recently I notices huge performance degradation in FF in our application. > > After some investigation I found it is caused by EmoticonsBehavior. > > > > According to github original JS plugin was not maintained for a long time > > But there is a fork: https://github.com/Caerostris/css-emoticons > > > > After switching to this new JS library performance degradation was fixed. > > > > I would propose PR with changes, but new JS version is no more > > jquery.plugin, just JS library ... > > Should I create PR, Or maybe EmoticonsBehavior should be dropped in > > wicket-8 version of wicket-jquery-ui ? > > > > > > -- > > WBR > > Maxim aka solomax > > > -- WBR Maxim aka solomax
