Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/210#discussion_r99945970
--- Diff:
wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
---
@@ -714,7 +714,7 @@ public boolean isNewPageInstance()
@Test
public void placeholderEncode4()
{
- PageProvider provider = new PageProvider(new MockPage())
+ PageProvider provider = new PageProvider(MockPage.class)
--- End diff --
I didn't understand you.
```java
/**
* WICKET-5247 page instantiated without required parameters won't be
mapped
*/
@Test
public void placeholderEncode4()
{
PageProvider provider = new PageProvider(new MockPage())
{
@Override
public boolean isNewPageInstance()
{
return false;
}
};
provider.setPageSource(context);
IRequestHandler handler = new
RenderPageRequestHandler(provider);
Url url = placeholderEncoder.mapHandler(handler);
assertNull(url);
}
```
The test setups a PageProvider and uses it. There is no replacement after.
By making this change I think we don't test the same as what broke in
WICKET-5247.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
