On Tue, Jun 13, 2017 at 9:39 PM, Sven Meier <[email protected]> wrote: > Hi Martin, > > note that component.getFeedbackMessages().clear(IFeedbackMessageFilter) > doesn't clear recursively. > It's not clear to me, what the proposed method does in this regard. >
Component#clearFeedbackMessages(IFMF) will clear only for this Component instance. MarkupContainer will override this method, call super to clean itself and use an IVisitor to clean all its children. > > Personally I don't see the need for such a method - I'd rather not broaden > the API with such seldom used cases. > OK. Since no one else responds then obviously it is not really needed. I'll add a comment to the ticket. > > Regards > Sven > > > > Am 13.06.2017 um 20:35 schrieb Martin Grigorov: > >> Hi Sven, >> >> On Wed, Jun 7, 2017 at 10:53 PM, Sven Meier <[email protected]> wrote: >> >> Hi, >>> >>> component.clearFeedbackMessages(IFeedbackMessageFilter) >>> with that method I don't know nor can I specify whether it operates >>> recursively or not. >>> >>> In what cases one will not want to be recursive ? >> Do you imagine such ? >> >> >> Regards >>> Sve >>> >>> >>> Am 07.06.2017 um 22:29 schrieb Martin Grigorov: >>> >>> Hi devs, >>>> >>>> At >>>> https://issues.apache.org/jira/browse/WICKET-6392?focusedCom >>>> mentId=16036791&page=com.atlassian.jira.plugin.system. >>>> issuetabpanels:comment-tabpanel#comment-16036791 >>>> the reporter suggested that we may have a nicer method for removing all >>>> FeedbackMessages for a Component than >>>> >>>> new FeedbackCollector(component).collect().stream().forEach(fm -> >>>> fm.markRendered()) >>>> >>>> e.g. component.clearFeedbackMessages(IFeedbackMessageFilter) >>>> >>>> Do you think this is a good addition to the Component API ? >>>> >>>> Martin Grigorov >>>> Wicket Training and Consulting >>>> https://twitter.com/mtgrigorov >>>> >>>> >>>> >
