I've added a CI-dedicated geocoder api key in the yml file. In this way CI failures should happened on much more sporadic basis.
On Mon, Feb 19, 2018 at 4:03 AM, Maxim Solodovnik <[email protected]> wrote: > Thanks Andrea, > > somehow I miss this difference, will fix the Test and perform release > later tonight! > > On Sun, Feb 18, 2018 at 10:30 PM, Andrea Del Bene <[email protected]> > wrote: > > I don't know why but on master we have > > 'assertFalse(session.isSessionInvalidated());' at the end of the tests > while > > on 7.x is assertTrue. It should be a simple typo. > > > > > > > > On 18/02/2018 15:02, Maxim Solodovnik wrote: > >> > >> Also got error at org.wicketstuff.security.SessionInvalidationTest > >> while running tests in wicket-7.x branch > >> According to code invalidate works and did > >> `RequestCycle.get().setMetaData(SESSION_INVALIDATED, true);` > >> > >> but later on > >> `RequestCycle.get().getMetaData(SESSION_INVALIDATED)` returns `true` > >> > >> don't get it :( > >> > >> On Sun, Feb 18, 2018 at 12:21 PM, Maxim Solodovnik < > [email protected]> > >> wrote: > >>> > >>> It seems it is impossible to create "secret" Travis command line option > >>> ... > >>> Is this true? > >>> > >>> Am I right thinking the only "correct Travis" way is via Environment > >>> variable? > >>> > >>> On Sun, Feb 18, 2018 at 11:38 AM, Maxim Solodovnik < > [email protected]> > >>> wrote: > >>>> > >>>> Have added possibility to specify API key via command line: > >>>> > >>>> https://github.com/wicketstuff/core/commit/ > e7d8ed7721a2dbcdb04082dac5c290c2d17d454b > >>>> Correct API key can be added in Travis config as well > >>>> > >>>> On Sun, Feb 18, 2018 at 2:42 AM, Andrea Del Bene < > [email protected]> > >>>> wrote: > >>>>> > >>>>> Locally you can temporary use the @ignore tag, but I'm afraid there's > >>>>> no > >>>>> way to bypass it on Travis. We can just wait long enough to re-run > the > >>>>> building, hoping that some one else hasn't already reached the query > >>>>> limit > >>>>> in the meantime. > >>>>> > >>>>> PS: on 7.x branch I see test > >>>>> org.wicketstuff.security.SessionInvalidationTest is failing. I > haven't > >>>>> investigated the problem yet but it could be something related to the > >>>>> changes to mock entities made with WICKET-6441. > >>>>> > >>>>> > >>>>> On 17/02/2018 17:16, Maxim Solodovnik wrote: > >>>>>> > >>>>>> Hello All, > >>>>>> > >>>>>> I have started local build of wickestuff right now and got following > >>>>>> errors: > >>>>>> I believe there might be limitation on query per day/per application > >>>>>> > >>>>>> What is the correct way to bypass this limitation? > >>>>>> > >>>>>> Thanks in advance! > >>>>>> > >>>>>> > >>>>>> ------------------------------------------------------- > >>>>>> T E S T S > >>>>>> ------------------------------------------------------- > >>>>>> Running wicket.contrib.gmap.util.GMapTest > >>>>>> log4j:WARN No appenders could be found for logger > >>>>>> (org.apache.wicket.Application). > >>>>>> log4j:WARN Please initialize the log4j system properly. > >>>>>> log4j:WARN See http://logging.apache.org/ > log4j/1.2/faq.html#noconfig > >>>>>> for > >>>>>> more info. > >>>>>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 0.358 > >>>>>> sec - > >>>>>> in wicket.contrib.gmap.util.GMapTest > >>>>>> Running wicket.contrib.gmap.util.GeocoderTest > >>>>>> Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: > 0.433 > >>>>>> sec > >>>>>> <<< FAILURE! - in wicket.contrib.gmap.util.GeocoderTest > >>>>>> testCenterAndFitZoomForAdress(wicket.contrib.gmap.util. > GeocoderTest) > >>>>>> Time > >>>>>> elapsed: 0.359 sec <<< ERROR! > >>>>>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT > >>>>>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130) > >>>>>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder. > java:182) > >>>>>> at > >>>>>> > >>>>>> > >>>>>> org.wicketstuff.gmap.geocoder.Geocoder.centerAndFitZoomForAdress( > Geocoder.java:254) > >>>>>> at > >>>>>> > >>>>>> > >>>>>> wicket.contrib.gmap.util.GeocoderTest. > testCenterAndFitZoomForAdress(GeocoderTest.java:61) > >>>>>> > >>>>>> testGeocoding(wicket.contrib.gmap.util.GeocoderTest) Time elapsed: > >>>>>> 0.074 > >>>>>> sec <<< ERROR! > >>>>>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT > >>>>>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130) > >>>>>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder. > java:182) > >>>>>> at > >>>>>> > >>>>>> wicket.contrib.gmap.util.GeocoderTest.testGeocoding( > GeocoderTest.java:41) > >>>>>> > >>>>>> > >>>>>> Results : > >>>>>> > >>>>>> Tests in error: > >>>>>> GeocoderTest.testCenterAndFitZoomForAdress:61 » Geocoder > >>>>>> OVER_QUERY_LIMIT > >>>>>> GeocoderTest.testGeocoding:41 » Geocoder OVER_QUERY_LIMIT > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>> > >>>> > >>>> -- > >>>> WBR > >>>> Maxim aka solomax > >>> > >>> > >>> > >>> > >>> -- > >>> WBR > >>> Maxim aka solomax > >> > >> > >> > > > > > > -- > WBR > Maxim aka solomax >
