Hi Peter,

This is strange.
We (Wicket team) do not own the repo at GitHub and we cannot close
issues/PRs there. But you as a reporter should be able to close your
issues/PRs.

I used the same tool to merge https://github.com/apache/wicket/pull/281 and
https://github.com/apache/wicket/pull/282 but only the former got closed
automatically.

https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commit;h=dd665ada719b6053829872cef10a0d73d8d43d13
looks good:
author Peter Lamby
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=dd665ada719b6053829872cef10a0d73d8d43d13;s=Peter+Lamby;st=author>
 <[email protected]>
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=dd665ada719b6053829872cef10a0d73d8d43d13;[email protected];st=author>
Mon, 4 Jun 2018 10:22:19 +0300 (09:22 +0200)
committer GitHub
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=dd665ada719b6053829872cef10a0d73d8d43d13;s=GitHub;st=committer>
 <[email protected]>
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=dd665ada719b6053829872cef10a0d73d8d43d13;[email protected];st=committer>
Mon, 4 Jun 2018 10:22:19 +0300 (09:22 +0200)
commit dd665ada719b6053829872cef10a0d73d8d43d13

The commit id is like from your fork. The 'committer' looks correct but
weird!

But
https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commit;h=a697cab87baf0dac10304bfeb446de7a962ac9c7
looks different:
author Peter Lamby
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=a697cab87baf0dac10304bfeb446de7a962ac9c7;s=Peter+Lamby;st=author>
 <[email protected]>
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=a697cab87baf0dac10304bfeb446de7a962ac9c7;[email protected];st=author>
Tue, 5 Jun 2018 13:44:51 +0300 (12:44 +0200)
committer Martin Tzvetanov Grigorov
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=a697cab87baf0dac10304bfeb446de7a962ac9c7;s=Martin+Tzvetanov+Grigorov;st=committer>
 <[email protected]>
<https://git1-us-west.apache.org/repos/asf/wicket/repo?p=wicket.git;a=search;h=a697cab87baf0dac10304bfeb446de7a962ac9c7;[email protected];st=committer>
Tue, 5 Jun 2018 15:57:48 +0300 (15:57 +0300)
commit a697cab87baf0dac10304bfeb446de7a962ac9c7

Here the commit hash is different than yours and the committer is me. This
is the reason why it is not automatically closed.
If you are not able to close the PR then we will have to ask Apache Infra
team to do it.


On Sat, Jun 9, 2018 at 10:38 AM, Peter Lamby <[email protected]>
wrote:

> I cannot close the PR myself :)
>
>
> On 05.06.2018 15:00, martin-g wrote:
>
>> Github user martin-g commented on the issue:
>>
>>      https://github.com/apache/wicket/pull/282
>>         Thank you!
>>
>>
>> ---
>>
>
>

Reply via email to