GitHub user ageery opened a pull request:
https://github.com/apache/wicket/pull/286
Basedataresource get filename
Allow the filename to be overridden by a sub-class of BaseDataResource.
My use-case is that the filename is stored in a database and I don't want
to have to have to determine what the filename is until the download is
actually requested.
Currently, however, the filename has to be specified in the constructor and
cannot be changed.
This allows a subclass to, for example, track the filename in a model, and
then get the value out of the model when filename is actually needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ageery/wicket basedataresource_getFilename
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit bfc3272422a72e847b2b67801b3b6480e41713c1
Author: ageery <andrew.geery@...>
Date: 2017-01-30T21:25:35Z
Add static lambda builder methods.
commit e8633135bb7627aa9676e6984b1ef783fba3922d
Author: ageery <andrew_geery@...>
Date: 2018-07-23T12:53:32Z
Merge remote-tracking branch 'upstream/master'
commit 2a22185282d6dedc3f18b773b0b8b8d21fd5fa28
Author: ageery <andrew_geery@...>
Date: 2018-07-23T15:39:55Z
Added an overrideable getFilename() method.
commit a9b3aaf76654b95462fb95842d986bd3ff06a983
Author: ageery <andrew_geery@...>
Date: 2018-07-24T10:25:26Z
Reverted change
commit 9987e0eec40a26e13accaf6810c587621ddca348
Author: ageery <andrew_geery@...>
Date: 2018-07-24T10:30:17Z
Added an overrideable getFilename() method.
commit 0a79b2fe52309e796aa12162752ca96ce63fceb6
Author: ageery <andrew_geery@...>
Date: 2018-07-24T10:31:20Z
Merge remote-tracking branch 'origin/basedataresource_getFilename' into
basedataresource_getFilename
----
---
