[GitHub] wicket pull request #294: WICKET-5552 fix modal mousedown and make modal mor...

[solomax]

Github user solomax commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/294#discussion_r220426844
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 
---
    @@ -2301,6 +2302,10 @@
                                        onDrag = jQuery.noop;
                                }
     
    +                           if (typeof(settings) !== "undefined" && 
settings.stopDragOnCssSelector) {
    --- End diff --
    
    According to the code `settings` should be `object`
    Maybe it would be better to change this line to be
    `typeof(settings) === 'object'` ?


---