Have created JIRA: https://issues.apache.org/jira/browse/WICKET-6615
Local wicket-7.x build fail with multiple JavaDoc errors, so I have to add <additionalparam>--allow-script-in-comments</additionalparam> To javadoc-plugin configuration No everything seems to work as expected On Sat, 24 Nov 2018 at 09:54, Maxim Solodovnik <[email protected]> wrote: > My plan was to apply it to wicket-8.x > No I see it should be applied to both wicket-7.x and wicket-8.x > Will do today > > On Sat, 24 Nov 2018 at 02:53, Sven Meier <[email protected]> wrote: > >> Hi Maxim, >> >> thanks, with these changes I was able to build Wicket 7.x on OpenJDK 8. >> >> On which branch are we going to apply them? >> >> Regards >> Sven >> >> >> Am 22.11.18 um 07:46 schrieb Maxim Solodovnik: >> > Sorry for multi-posting >> > >> > Just have performed one last test maven-surefire-plugin:3.0.0-M1 + >> > useSystemClassLoader=false >> > And all tests are green under both JDKs >> > >> > >> > On Thu, 22 Nov 2018 at 12:26, Maxim Solodovnik <[email protected]> >> wrote: >> > >> >> Hello All, >> >> >> >> After one evening of struggling with CDI tests I give up :( >> >> >> >> Tried to change cdi-unit version, some suggestions from internet, >> nothing >> >> works >> >> Will contact Maven community, maybe they can suggest something >> >> >> >> Same time adding `<useSystemClassLoader>false</useSystemClassLoader>` >> >> fixes the problem >> >> So this can be used while surefire 3.0.0-M1 is not working >> >> >> >> On Wed, 21 Nov 2018 at 19:35, Maxim Solodovnik <[email protected]> >> >> wrote: >> >> >> >>> Will try to check ASAP what is wrong with CDI tests >> >>> They pass with Oracle JDK and old surefire >> >>> Will report back here >> >>> >> >>> WBR, Maxim >> >>> (from mobile, sorry for the typos) >> >>> >> >>> On Wed, Nov 21, 2018, 19:22 Andrea Del Bene <[email protected] >> wrote: >> >>> >> >>>> +1 to change surefire version >> >>>> >> >>>> On Wed, Nov 21, 2018 at 12:53 PM Maxim Solodovnik < >> [email protected]> >> >>>> wrote: >> >>>> >> >>>>> Hello All, >> >>>>> >> >>>>> just have tried the following: >> >>>>> 0) set default JDK to be OpenJDK-8 (latest on Ubuntu 16) >> >>>>> 1) checkout branch 8.x >> >>>>> 2) mvn clean install >> >>>>> Result: build fails >> >>>>> >> >>>>> 3) Changed maven.surefire.version to be 3.0.0-M1 >> >>>>> 4) mvn clean install >> >>>>> Result: success >> >>>>> >> >>>>> I propose to update surefire version :) >> >>>>> >> >>>>> >> >>>>> On Wed, 21 Nov 2018 at 00:59, Martin Grigorov <[email protected] >> > >> >>>>> wrote: >> >>>>> >> >>>>>> >> >>>> >> https://github.com/brix-cms/brix-cms/pull/229/files#diff-600376dffeb79835ede4a0b285078036R549 >> >>>>>> On Tue, Nov 13, 2018 at 5:15 AM Maxim Solodovnik < >> >>>> [email protected]> >> >>>>>> wrote: >> >>>>>> >> >>>>>>> Hello Andrea, >> >>>>>>> >> >>>>>>> Accepted answer at StackOverflow states "supposedly fixed in >> >>>> surefire >> >>>>>>> 3.0.0-M1 <https://issues.apache.org/jira/browse/SUREFIRE-1588>" >> >>>>>>> According to >> >>>> https://maven.apache.org/surefire/maven-surefire-plugin/ >> >>>>>>> 3.0.0-M1 is already released >> >>>>>>> >> >>>>>>> So the fix should be as simple as >> >>>>>>> -- <maven.surefire.version>2.20</maven.surefire.version> >> >>>>>>> ++ <maven.surefire.version>3.0.0-M1</maven.surefire.version> >> >>>>>>> >> >>>>>>> in main pom :) >> >>>>>>> >> >>>>>>> BTW I see no issues with my builds, maybe because I'm using Oracle >> >>>>>>> jdk 1.8.0_191 >> >>>>>>> >> >>>>>>> I can check pom and update all plugins to most recent version :) >> >>>>>>> >> >>>>>>> On Tue, 13 Nov 2018 at 01:54, Andrea Del Bene < >> >>>> [email protected]> >> >>>>>>> wrote: >> >>>>>>> >> >>>>>>>> Have you any suggestion for an alternative plugin? >> >>>>>>>> >> >>>>>>>> On 11/11/18 05:55, Maxim Solodovnik wrote: >> >>>>>>>>> Time to switch to new, fixed surefire plugin? >> >>>>>>>>> >> >>>>>>>>> WBR, Maxim >> >>>>>>>>> (from mobile, sorry for the typos) >> >>>>>>>>> >> >>>>>>>>> On Sun, Nov 11, 2018, 02:30 Tobias Soloschenko >> >>>>>>>>> <[email protected] wrote: >> >>>>>>>>> >> >>>>>>>>>> Thanks for sharing! >> >>>>>>>>>> >> >>>>>>>>>> kind regards >> >>>>>>>>>> >> >>>>>>>>>> Tobias >> >>>>>>>>>> >> >>>>>>>>>>> Am 10.11.2018 um 17:10 schrieb Andrea Del Bene < >> >>>>>> [email protected] >> >>>>>>>> : >> >>>>>>>>>>> FYI: there's a nasty bug with the last Java 8 version and the >> >>>>>>> Surefire >> >>>>>>>>>> plugin. Here you can find more info and a workaround: >> >>>>>>>>>>> https://stackoverflow.com/a/53016532/1676516 >> >>>>>>>>>>> >> >>>>>>> >> >>>>>>> -- >> >>>>>>> WBR >> >>>>>>> Maxim aka solomax >> >>>>>>> >> >>>>> >> >>>>> -- >> >>>>> WBR >> >>>>> Maxim aka solomax >> >>>>> >> >>>> >> >>>> -- >> >>>> Andrea Del Bene. >> >>>> Apache Wicket committer. >> >>>> >> >> -- >> >> WBR >> >> Maxim aka solomax >> >> >> > >> > > > -- > WBR > Maxim aka solomax > -- WBR Maxim aka solomax
