Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238121519
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
---
@@ -161,19 +161,19 @@ public final void onComponentTagBody(MarkupStream
markupStream, ComponentTag ope
final StringResponse response = new StringResponse();
getRequestCycle().setResponse(response);
- IHeaderResponse headerResponse = getHeaderResponse();
- if (!response.equals(headerResponse.getResponse()))
- {
-
getRequestCycle().setResponse(headerResponse.getResponse());
- }
+ try (IHeaderResponse headerResponse =
getHeaderResponse()) {
+ if
(!response.equals(headerResponse.getResponse()))
+ {
+
getRequestCycle().setResponse(headerResponse.getResponse());
+ }
- // Render the header sections of all components on the
page
- AbstractHeaderRenderStrategy.get().renderHeader(this,
- new HeaderStreamState(markupStream, openTag),
getPage());
+ // Render the header sections of all components
on the page
+
AbstractHeaderRenderStrategy.get().renderHeader(this,
+ new HeaderStreamState(markupStream,
openTag), getPage());
- // Close the header response before rendering the
header container itself
- // See https://issues.apache.org/jira/browse/WICKET-3728
- headerResponse.close();
--- End diff --
`close()` is being called automatically by `try with resource` statement
I'll modify comment
---
