Hello, could you please review my changes? https://github.com/apache/wicket/pull/351
I see no reason to change signatures of other methods due to respond and completed/failed are ajax based On Thu, 4 Apr 2019 at 15:09, Maxim Solodovnik <[email protected]> wrote: > > It might be good idea to rename and deprecate current behavior, but I > can't imagine better name :) > > On Thu, 4 Apr 2019 at 14:51, Martin Grigorov <[email protected]> wrote: > > > > Hi, > > > > Should we rename the behavior as well, since it won't be Ajax specific > > anymore ? > > I do not have a good suggestion for the name though. > > > > On Thu, Apr 4, 2019 at 9:13 AM Maxim Solodovnik <[email protected]> > > wrote: > > > > > Thanks Sven, > > > > > > will do it tonight! > > > > > > On Thu, 4 Apr 2019 at 02:49, Sven Meier <[email protected]> wrote: > > > > > > > > Hi, > > > > > > > > we should change all methods in 9.x > > > > > > > > For 8.x we can make it work with overloaded methods, while deprecating > > > > the current ones. > > > > > > > > Have fun > > > > Sven > > > > > > > > > > > > Am 03.04.19 um 19:03 schrieb Maxim Solodovnik: > > > > > Hello All, > > > > > > > > > > I would like to change signature of 2 methods of AjaxDownloadBehavior: > > > > > > > > > > - public void initiate(AjaxRequestTarget target) > > > > > + public void initiate(IPartialPageRequestHandler handler) > > > > > > > > > > - protected void onBeforeDownload(AjaxRequestTarget target) > > > > > + protected void onBeforeDownload(IPartialPageRequestHandler > > > target) > > > > > > > > > > This change looks correct and will allow to initiate download by > > > > > websocket message > > > > > > > > > > Unfortunately this would be API break :( > > > > > > > > > > Are there elegant options to bypass this limitation? > > > > > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax
