martin-g commented on a change in pull request #352: WICKET-6649 Store the
applicationName, sessionId and key in WebSocket…
URL: https://github.com/apache/wicket/pull/352#discussion_r272461990
##########
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/message/BinaryMessage.java
##########
@@ -16,29 +16,57 @@
*/
package org.apache.wicket.protocol.ws.api.message;
+import org.apache.wicket.Application;
+import org.apache.wicket.Session;
+import org.apache.wicket.mock.MockApplication;
+import org.apache.wicket.protocol.ws.api.registry.IKey;
+
/**
* A {@link IWebSocketMessage message} with binary data
*
* @since 6.0
*/
-public class BinaryMessage implements IWebSocketMessage
+public class BinaryMessage extends AbstractClientMessage
{
private final byte[] data;
private final int offset;
private final int length;
/**
- * Constructor.
+ * Not used by Wicket since 8.5.0!
*
* @param data
* the binary message from the client
* @param offset
* the offset to read from
* @param length
- * how much data to read
+ * the length of the data to read
*/
+ @Deprecated
public BinaryMessage(byte[] data, int offset, int length)
{
+ this(new MockApplication(), "", new IKey() {}, data, offset,
length);
Review comment:
Is this acceptable ?
It is needed to be able to downport the improvement made in Wicket 9.x.
This constructor is used only by Wicket. I do not expect the user
application to have made use of it, but I cannot be fully certain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
