I've appied it manually. Wicket-8.x uses JUnit 4.x and the cherry-pick breaks many things.
On Thu, Apr 18, 2019 at 2:39 PM Maxim Solodovnik <[email protected]> wrote: > Could you also cherry-pick the fix to wicket-8.x? > > On Thu, 18 Apr 2019 at 18:28, Maxim Solodovnik <[email protected]> > wrote: > > > > Thanks a million! > > > > On Thu, 18 Apr 2019 at 18:27, Martin Grigorov <[email protected]> > wrote: > > > > > > I've fixed it: > > > > https://github.com/wicketstuff/core/commit/b2ec4ad4637fe56b412123ef98368d8a549e91e0 > > > > > > On Thu, Apr 18, 2019 at 10:33 AM Maxim Solodovnik < > [email protected]> > > > wrote: > > > > > > > #3 is really weird > > > > It works for me (local build) > > > > but fails travis builds, will try to take a look at the code > > > > > > > > On Thu, 18 Apr 2019 at 14:24, Martin Grigorov <[email protected]> > > > > wrote: > > > > > > > > > > Here it also fails with: > > > > > > > > > > 3) > > > > > [ERROR] Failures: > > > > > [ERROR] > JamonAdminPageTest.shouldRenderStatisticsPageWithOneMonitor:55 > > > > > expected: <1> but was: <2> > > > > > [INFO] > > > > > [ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 2 > > > > > [INFO] > > > > > > > > > > > > > > > On Thu, Apr 18, 2019 at 9:46 AM Maxim Solodovnik < > [email protected]> > > > > > wrote: > > > > > > > > > > > Hello All, > > > > > > > > > > > > Will update this thread with all wicketstuff-9 issues found so > far > > > > > > > > > > > > 1) wicket-bundle-parent fails to build with > maven-bundle-plugin:4.2.0 > > > > > > (works as expected with maven-bundle-plugin:4.1.0) > > > > > > > > > > > > [INFO] --- maven-bundle-plugin:4.2.0:bundle (default-bundle) @ > > > > > > wicketstuff-bundle --- > > > > > > [ERROR] An internal error occurred > > > > > > java.lang.IllegalArgumentException: A Jar can only accept a file > or > > > > > > directory that exists: > > > > > > > > > > > > > > > > > /home/solomax/work/wicketstuff-core/wicket-bundle-parent/wicket-bundle/target/classes > > > > > > at aQute.bnd.osgi.Jar.<init> (Jar.java:124) > > > > > > at aQute.bnd.osgi.Jar.<init> (Jar.java:172) > > > > > > at org.apache.felix.bundleplugin.BundlePlugin.getOSGiBuilder > > > > > > (BundlePlugin.java:603) > > > > > > > > > > > > 2) Possible problem: select2-examples > > > > > > mvn jetty:run > > > > > > > > > > > > Produces following output as soon as localhost:8080 is accessed: > > > > > > > > > > > > [INFO] Started Jetty Server > > > > > > WARNING: An illegal reflective access operation has occurred > > > > > > WARNING: Illegal reflective access by > > > > > > > > > > > org.apache.wicket.core.util.lang.PropertyResolver$DefaultPropertyLocator > > > > > > > > > > > > > > > > > (file:/home/solomax/.m2/repository/org/apache/wicket/wicket-core/9.0.0-M2-SNAPSHOT/wicket-core-9.0.0-M2-SNAPSHOT.jar) > > > > > > to field java.lang.Enum.name > > > > > > WARNING: Please consider reporting this to the maintainers of > > > > > > > > > > > org.apache.wicket.core.util.lang.PropertyResolver$DefaultPropertyLocator > > > > > > WARNING: Use --illegal-access=warn to enable warnings of further > > > > > > illegal reflective access operations > > > > > > WARNING: All illegal access operations will be denied in a future > > > > release > > > > > > > > > > > > will keep you posted :) > > > > > > -- > > > > > > WBR > > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > > > > > -- > > > > WBR > > > > Maxim aka solomax > > > > > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax >
