martin-g commented on a change in pull request #354: ReplaceAll() to replace()
for non-regex patterns
URL: https://github.com/apache/wicket/pull/354#discussion_r277147275
##########
File path: wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
##########
@@ -170,7 +170,7 @@ public static boolean isFalse(final boolean argument,
final String msg, final Ob
*/
static String format(String msg, final Object... params)
{
- msg = msg.replaceAll("\\{\\}", "%s");
+ msg = msg.replace("\\{\\}", "%s");
Review comment:
Is the behavior the same ?
I think we need to remove the `\\` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
