bitstorm commented on a change in pull request #356: Wicket 6662
URL: https://github.com/apache/wicket/pull/356#discussion_r281580379
##########
File path:
wicket-jmx/src/main/java/org/apache/wicket/jmx/wrapper/RequestCycleSettings.java
##########
@@ -117,9 +117,9 @@ public void setResponseRequestEncoding(final String
responseRequestEncoding)
* @see
org.apache.wicket.jmx.RequestCycleSettingsMBean#setTimeout(java.lang.String)
*/
@Override
- public void setTimeout(final String timeout)
+ public void setTimeout(final Duration timeout)
Review comment:
@martin-g I think you've lost me here :-). The old version of this method
took in input a String and used a custom 'human-friendly' format to build a
duration. For example something like '1.5 days' would have been converted into
36 hours. I've simply removed this textual format in order to use directly a
standard Duration class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
